fix(web): align DS package version with primitive imports - #30749
Closed
joechaotic wants to merge 2 commits into
Closed
fix(web): align DS package version with primitive imports#30749joechaotic wants to merge 2 commits into
joechaotic wants to merge 2 commits into
Conversation
Replace locally-forked UI components and hooks with their newly
promoted counterparts from @nous-research/ui:
Deleted local components (now in DS):
- components/ui/input.tsx, label.tsx, separator.tsx, card.tsx,
confirm-dialog.tsx
- components/Toast.tsx, BottomPickSheet.tsx, NouiTypography.tsx
- hooks/useToast.ts, useModalBehavior.ts, useBelowBreakpoint.ts,
useConfirmDelete.ts
Import updates across 25 files to use DS deep imports:
- @nous-research/ui/ui/components/{input,label,separator,card,
confirm-dialog,toast,bottom-sheet}
- @nous-research/ui/ui/components/typography (replaces NouiTypography)
- @nous-research/ui/hooks/{use-toast,use-modal-behavior,
use-below-breakpoint,use-confirm-delete}
Requires design-language >= feat/promote-hermes-web-primitives.
Co-authored-by: Cursor <cursoragent@cursor.com>
joechaotic
force-pushed
the
wade/fix-30698-ds-nix
branch
from
May 23, 2026 04:30
04ad5d9 to
b0fe829
Compare
17 tasks
alt-glitch
added
type/refactor
Contributor
|
Automated hermes-sweeper review: this PR’s functional changes are already present on current Evidence:
|
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Supersedes/repairs #30698 by updating @nous-research/ui to a version that exports the DS primitive subpaths used by the web refactor.\n- Updates package-lock so Nix/npm builds resolve the same DS package locally and in CI.\n- Keeps useModalBehavior local because @nous-research/ui does not export that hook.\n\n## Test Plan\n- npm run build (from web/)\n- git diff --check\n\nNotes: I could not push directly to the original branch (#30698) because this checkout has read-only permission on NousResearch/hermes-agent.