fix(auxiliary): add minimax-oauth support to resolve_provider_client - #30497
Closed
ilonagaja509-glitch wants to merge 2 commits into
Closed
fix(auxiliary): add minimax-oauth support to resolve_provider_client#30497ilonagaja509-glitch wants to merge 2 commits into
ilonagaja509-glitch wants to merge 2 commits into
Conversation
OAuth providers with auth_type=oauth_minimax (minimax-oauth) were not handled in resolve_provider_client(), causing auto-detection (auxiliary.kanban_decomposer=auto) to fail with AuthenticationError when the main provider is minimax-oauth. Fixes NousResearch#29910
Collaborator
keegoid-codex
left a comment
There was a problem hiding this comment.
Bugs
- [CAT-1] Import failure catches only
ImportError;build_anthropic_client()runtime errors escapeagent/auxiliary_client.py:3683.
Severity
- medium. Missing credential/client error path can break auxiliary resolver at runtime.
VERDICT: request_changes
codex-review posting override: forced to --comment because reviewer lacks verified write permission (viewerPermission=READ; was --request-changes). GitHub only counts approvals from WRITE, MAINTAIN, or ADMIN reviewers.
|
[DEV SecOps] verdict: PASS
|
keegoid-codex
left a comment
There was a problem hiding this comment.
Bugs
- [CAT-1] Preserve prior blocker:
build_anthropic_client()exceptions bypass fallbackagent/auxiliary_client.py:3683.
Severity
- medium. Unhandled MiniMax OAuth client failures break auxiliary resolution.
VERDICT: request_changes
codex-review posting override: forced to --comment because reviewer lacks verified write permission (viewerPermission=READ; was --request-changes). GitHub only counts approvals from WRITE, MAINTAIN, or ADMIN reviewers.
|
[DEV SecOps] verdict: PASS
|
Wrap the entire minimax-oauth client creation block in try/except Exception to handle AuthError from resolve_minimax_oauth_runtime_credentials() and any errors from build_anthropic_client(), not just ImportError. Follows the pattern used for Nous OAuth in _resolve_nous_runtime_api().
Contributor
Author
|
Closing as duplicate of #23639 which addresses the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22213
Adds minimax-oauth provider support to the auxiliary provider resolver.