fix(qqbot): add INTERACTION_CREATE intent + preserve original filename - #30484
Closed
ericshonnon-maker wants to merge 1 commit into
Closed
fix(qqbot): add INTERACTION_CREATE intent + preserve original filename#30484ericshonnon-maker wants to merge 1 commit into
ericshonnon-maker wants to merge 1 commit into
Conversation
- Add (1 << 26) INTERACTION_CREATE intent so button click events are received - Pass original_filename to _download_and_cache() to preserve file extension (e.g. .md attachments were saved without extension, breaking file type detection) - Update all call sites of _download_and_cache()
alt-glitch
added
type/bug
Collaborator
|
Duplicate of #27944 — both PRs add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugfixes for the QQBot adapter:
1. Missing INTERACTION_CREATE intent (button clicks broken)
Added
(1 << 26) # INTERACTION_CREATEto the intents flags. Without this, button click interactions are silently ignored by the QQ platform gateway.2. Attachment filename extension lost
_download_and_cache()was using the URL path as the filename, losing the original extension (e.g..mdfiles were saved without extension). Now passes theoriginal_filenamefrom the QQ message so extensions are preserved.Files changed
gateway/platforms/qqbot/adapter.pySubmitted via Hermes Agent on behalf of ericshonnon-maker