fix(anthropic): guard credential-pool recovery check - #30377
Closed
GirthTender wants to merge 5 commits into
Closed
Conversation
alt-glitch
added
type/bug
Collaborator
|
Duplicate of #28345 (merged) — Additionally, this PR bundles unrelated personal account management docs ( |
Author
|
Closing this because upstream main already carries the fix via merged #28345, and this branch/PR is not a clean minimal delta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the missing _pool_may_recover_from_rate_limit helper used by the Anthropic/API-billing recovery path. Without it, the recovery path can crash with NameError after a provider failure. The helper is conservative: it returns false when there is no pool or only one credential, true only when another credential can realistically recover, and otherwise falls back normally. Verified with python -m py_compile agent\conversation_loop.py and targeted helper cases covering no pool, single credential, healthy alternate credential, future cooldown, expired cooldown, and exhausted/no-reset status.