fix(skills): add 429 rate limit retry to GitHub Contents API fallback - #3033
Closed
0xbyt4 wants to merge 1 commit into
Closed
fix(skills): add 429 rate limit retry to GitHub Contents API fallback#30330xbyt4 wants to merge 1 commit into
0xbyt4 wants to merge 1 commit into
Conversation
When Git Trees API falls back to the recursive Contents API (truncated tree or API unavailable), rate-limited responses (HTTP 429) caused silent subdirectory loss — files were skipped with only a DEBUG log, and the skill was recorded as fully installed. Added retry with Retry-After header support (3 attempts, 15s cap) to both _download_directory_recursive and _fetch_file_content. Matches the existing retry pattern in ClawHub source. Also: guard against non-numeric Retry-After headers (HTTP-date format), promote tree truncation log to INFO level.
19 tasks
teknium1
added a commit
that referenced
this pull request
Jul 5, 2026
…-retry fix(skills): retry rate-limited Contents API directory listings (salvage #3033)
liuhao1024
pushed a commit
to liuhao1024/hermes-agent
that referenced
this pull request
Jul 5, 2026
The Contents-API fallback's directory listing used a raw httpx.get with no retry, so a 429/403 rate limit aborted the whole skill download even though file fetches already retry via _github_get. Route the directory listing through the same helper (429/reset-aware backoff, 5xx retry, rate-limit flagging). Salvage of PR NousResearch#3033's intent — rerouted through the _github_get helper that landed after the PR was opened, instead of the PR's ad-hoc retry loops. Co-authored-by: 0xbyt4 <35742124+0xbyt4@users.noreply.github.com>
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
The Contents-API fallback's directory listing used a raw httpx.get with no retry, so a 429/403 rate limit aborted the whole skill download even though file fetches already retry via _github_get. Route the directory listing through the same helper (429/reset-aware backoff, 5xx retry, rate-limit flagging). Salvage of PR NousResearch#3033's intent — rerouted through the _github_get helper that landed after the PR was opened, instead of the PR's ad-hoc retry loops. Co-authored-by: 0xbyt4 <35742124+0xbyt4@users.noreply.github.com>
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…contents-api-retry fix(skills): retry rate-limited Contents API directory listings (salvage NousResearch#3033)
Contributor
|
Thanks for identifying the silent Contents API fallback failure mode. This is an automated hermes-sweeper review; the implementation has already landed on
This shipped in |
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
The Contents-API fallback's directory listing used a raw httpx.get with no retry, so a 429/403 rate limit aborted the whole skill download even though file fetches already retry via _github_get. Route the directory listing through the same helper (429/reset-aware backoff, 5xx retry, rate-limit flagging). Salvage of PR NousResearch#3033's intent — rerouted through the _github_get helper that landed after the PR was opened, instead of the PR's ad-hoc retry loops. Co-authored-by: 0xbyt4 <35742124+0xbyt4@users.noreply.github.com>
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…contents-api-retry fix(skills): retry rate-limited Contents API directory listings (salvage NousResearch#3033)
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
The Contents-API fallback's directory listing used a raw httpx.get with no retry, so a 429/403 rate limit aborted the whole skill download even though file fetches already retry via _github_get. Route the directory listing through the same helper (429/reset-aware backoff, 5xx retry, rate-limit flagging). Salvage of PR NousResearch#3033's intent — rerouted through the _github_get helper that landed after the PR was opened, instead of the PR's ad-hoc retry loops. Co-authored-by: 0xbyt4 <35742124+0xbyt4@users.noreply.github.com>
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…contents-api-retry fix(skills): retry rate-limited Contents API directory listings (salvage NousResearch#3033)
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
The Contents-API fallback's directory listing used a raw httpx.get with no retry, so a 429/403 rate limit aborted the whole skill download even though file fetches already retry via _github_get. Route the directory listing through the same helper (429/reset-aware backoff, 5xx retry, rate-limit flagging). Salvage of PR NousResearch#3033's intent — rerouted through the _github_get helper that landed after the PR was opened, instead of the PR's ad-hoc retry loops. Co-authored-by: 0xbyt4 <35742124+0xbyt4@users.noreply.github.com>
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…contents-api-retry fix(skills): retry rate-limited Contents API directory listings (salvage NousResearch#3033)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Git Trees API falls back to the recursive Contents API (truncated tree or API unavailable), HTTP 429 rate-limited responses caused silent subdirectory loss:
This adds retry with
Retry-Afterheader support to both_download_directory_recursiveand_fetch_file_content:Retry-Afterheader, capped at 15s)Retry-Aftervalues (HTTP-date format)ClawHub._download_zip(line ~1729)Log levels follow codebase convention:
debug: individual retry attempts, non-200 responses, network errorsinfo: tree truncation (normal for large repos)warning: only when all 3 retries exhausted (actual data loss risk)Test plan
tests/tools/test_skills_hub.py— 73/73 passedint(Retry-After)guarded with try/except for non-numeric headers