fix: preserve MCP embedded resource text - #29962
Conversation
|
Duplicate of open PR #13736 which implements the same EmbeddedResource text extraction fix. Please coordinate with that PR. |
|
Thanks for the focused regression coverage. The premise is confirmed on current Suggested changes
This is an automated hermes-sweeper review. |
|
This bug is now fixed on main via PR #64556 (salvaged from #64061). Your PR was the earliest report and fix for the dropped EmbeddedResource text — submitted May 21, well before the others — and that priority is acknowledged. We merged the #64061 implementation because it additionally materializes binary blob resources (PDFs etc.) to the document cache, handles ResourceLink and Audio blocks, and ships size caps + hostile-input tests. Thanks for catching this first! |
Summary
EmbeddedResource.resource.textblocks when rendering tool results.Tests
./venv/bin/python3 -m pytest tests/tools/test_mcp_structured_content.py tests/tools/test_mcp_image_content.py tests/tools/test_mcp_tool_session_expired.py -q→ 34 passedNotes
getreturning the expected document text instead of an empty payload.