test(tools): regression test for Windows creationflags double-pass (#29651) - #29944
Closed
Snehal707 wants to merge 1 commit into
Closed
test(tools): regression test for Windows creationflags double-pass (#29651)#29944Snehal707 wants to merge 1 commit into
Snehal707 wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
Thanks for adding a focused regression guard. This automated hermes-sweeper review found that the reported Windows double-pass is already fixed on current
Closing as implemented on main. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a regression test ensuring
LocalEnvironment._run_bashpassescreationflagsonly once on Windows.Related to #29651
What was happening
On Windows,
subprocess.Popen()inLocalEnvironment._run_bashreceivedcreationflagstwice: once as an explicit keyword (CREATE_NO_WINDOW) and again via**_popen_kwargs(windows_hide_flags()). That raisedgot multiple values for keyword argument 'creationflags', breakingterminal()andwrite_file()on the local backend.What changed
tests/tools/test_local_popen_creationflags.pyHow to verify
pytest tests/tools/test_local_popen_creationflags.py -q(on Windows use--timeout-method=threadif needed)terminal(command="echo hello")andwrite_file(path="test.txt", content="test")should succeed.Platforms tested