fix(auth): preserve custom:<subname> in credential pool lookup (fixes #29872) - #29893
Closed
vanhci wants to merge 4 commits into
Closed
fix(auth): preserve custom:<subname> in credential pool lookup (fixes #29872)#29893vanhci wants to merge 4 commits into
vanhci wants to merge 4 commits into
Conversation
On Windows, subprocess.Popen spawned the Node.js WhatsApp bridge without creationflags, causing a visible blank node.exe console window to appear. The window has no useful output (stdout/stderr already go to bridge.log) and closing it causes the bridge to exit with status 0xC000013A, triggering the reconnection watcher loop. Fix: pass creationflags=windows_hide_flags() on Windows, the same pattern already used in cron/scheduler.py for the same reason. Fixes #29715
Fixes #29750 — Traditional Chinese language option showed the Taiwan flag (tw) instead of the PRC five-star red flag (cn). Both Simplified and Traditional Chinese now correctly display the PRC flag, matching the dashboard language selector consistency expectation.
alt-glitch
added
area/auth
toxuin
reviewed
May 21, 2026
| en: { name: "English", flagCountryCode: "gb" }, | ||
| zh: { name: "简体中文", flagCountryCode: "cn" }, | ||
| "zh-hant": { name: "繁體中文", flagCountryCode: "tw" }, | ||
| "zh-hant": { name: "繁體中文", flagCountryCode: "cn" }, |
There was a problem hiding this comment.
This change doesn't seem to be related to the rest of the PR.
toxuin
suggested changes
May 21, 2026
toxuin
left a comment
toxuin
left a comment
There was a problem hiding this comment.
This seems to be addressing several issues at once. I would recommend splitting it into individual PRs.
Description clearly states changes/fix to auth only, failing to mention other changes (cosmetic flag change, new _is_windows platform condition).
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #29872 where
provider: custom:<subname>(e.g.custom:bobapi-deepseek) inmodel_aliaseswould lose the sub-name during credential pool lookup, causing wrong credentials to be picked when multiple custom providers share the same base_url.Root Cause
In
_resolve_named_custom_runtime()at line 638, the pool lookup was called withprovider_name=Nonefor the bare-custompath, falling back to url-only matching instead of name-based matching.Fix
Extract the sub-name from
requested_provider(e.g.bobapi-deepseekfromcustom:bobapi-deepseek) and pass it to_try_resolve_from_custom_pool()so the credential pool lookup can use name-based matching.Testing
After this fix,
provider=custom:bobapi-deepseekwill correctly look up thecustom:bobapi-deepseekpool key instead of falling back to url-only matching.Closes #29872