Skip to content

chore: add contributor attribution for mihalyschroth - #29876

Closed
mihalyschroth wants to merge 2 commits into
NousResearch:mainfrom
mihalyschroth:fix/mihaly-contributor-attribution-forkbase
Closed

mihalyschroth wants to merge 2 commits into
NousResearch:mainfrom
mihalyschroth:fix/mihaly-contributor-attribution-forkbase

Conversation

@mihalyschroth

Copy link
Copy Markdown

Summary

  • Add contributor attribution mapping for mihaly.schroth@gmail.com to mihalyschroth.

Test Plan

  • python3 -m py_compile scripts/release.py
  • Verified scripts/release.py contains the expected AUTHOR_MAP entry.

Scope

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have labels May 21, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributor-attribution update. The requested mapping remains useful: current scripts/release.py:47 has no entry for this email, and resolve_author() consults AUTHOR_MAP at scripts/release.py:2150 before falling back to the bare git name.

Problems

  • The submitted diff is not limited to the stated mapping: gh pr diff 29876 reports +100/-1 in scripts/release.py, including numerous unrelated mappings and a separate replacement for jonny@nousresearch.com. That broad snapshot should not be merged with this focused attribution change.
  • GitHub reports this PR as conflicting, so it requires manual salvage rather than a clean cherry-pick.

Suggested changes

  • Retain only "mihaly.schroth@gmail.com": "mihalyschroth" against the current AUTHOR_MAP in scripts/release.py.
  • Submit unrelated mapping changes separately with their supporting attribution evidence.

Automated hermes-sweeper review.

Comment thread scripts/release.py
AUTHOR_MAP = {
# teknium (multiple emails)
"teknium1@gmail.com": "teknium1",
"mihaly.schroth@gmail.com": "mihalyschroth",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain this requested mapping but remove the unrelated snapshot entries from this PR. The current diff is +100/-1 and includes a separate existing-mapping replacement, despite the stated one-mapping scope.

@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 13, 2026
@teknium1

teknium1 commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

The mappings from this PR are landing on main via #77132 as contributors/emails/ files, with credit — the AUTHOR_MAP dict this PR edits is frozen (per-email files are the conflict-free replacement; #77116 added scripts/audit_pr_attribution.py --fix to generate them automatically). Entries already mapped on main were skipped. Closing in favor of #77132 — thanks for keeping attribution clean.

@teknium1 teknium1 closed this Aug 2, 2026
teknium1 added a commit that referenced this pull request Aug 2, 2026
Consolidates the surviving mappings from PRs #53509 (@xqdwww),
#29876 (@mihalyschroth), and #32842 (@vizicist, for @waefrebeorn's
bounty account) into contributors/emails/ files — the frozen
AUTHOR_MAP in release.py is not edited (the reason those PRs
couldn't merge as-is). Entries from those PRs already present on
main are skipped. All bare-noreply logins verified via the GitHub
users API.

Salvaged from @xqdwww (#53509), @mihalyschroth (#29876),
@vizicist (#32842).
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww),
NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's
bounty account) into contributors/emails/ files — the frozen
AUTHOR_MAP in release.py is not edited (the reason those PRs
couldn't merge as-is). Entries from those PRs already present on
main are skipped. All bare-noreply logins verified via the GitHub
users API.

Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876),
@vizicist (NousResearch#32842).
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww),
NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's
bounty account) into contributors/emails/ files — the frozen
AUTHOR_MAP in release.py is not edited (the reason those PRs
couldn't merge as-is). Entries from those PRs already present on
main are skipped. All bare-noreply logins verified via the GitHub
users API.

Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876),
@vizicist (NousResearch#32842).
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww),
NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's
bounty account) into contributors/emails/ files — the frozen
AUTHOR_MAP in release.py is not edited (the reason those PRs
couldn't merge as-is). Entries from those PRs already present on
main are skipped. All bare-noreply logins verified via the GitHub
users API.

Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876),
@vizicist (NousResearch#32842).
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww),
NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's
bounty account) into contributors/emails/ files — the frozen
AUTHOR_MAP in release.py is not edited (the reason those PRs
couldn't merge as-is). Entries from those PRs already present on
main are skipped. All bare-noreply logins verified via the GitHub
users API.

Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876),
@vizicist (NousResearch#32842).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants