chore: add contributor attribution for mihalyschroth - #29876
mihalyschroth wants to merge 2 commits into
Conversation
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the contributor-attribution update. The requested mapping remains useful: current scripts/release.py:47 has no entry for this email, and resolve_author() consults AUTHOR_MAP at scripts/release.py:2150 before falling back to the bare git name.
Problems
- The submitted diff is not limited to the stated mapping:
gh pr diff 29876reports+100/-1inscripts/release.py, including numerous unrelated mappings and a separate replacement forjonny@nousresearch.com. That broad snapshot should not be merged with this focused attribution change. - GitHub reports this PR as conflicting, so it requires manual salvage rather than a clean cherry-pick.
Suggested changes
- Retain only
"mihaly.schroth@gmail.com": "mihalyschroth"against the currentAUTHOR_MAPinscripts/release.py. - Submit unrelated mapping changes separately with their supporting attribution evidence.
Automated hermes-sweeper review.
| AUTHOR_MAP = { | ||
| # teknium (multiple emails) | ||
| "teknium1@gmail.com": "teknium1", | ||
| "mihaly.schroth@gmail.com": "mihalyschroth", |
There was a problem hiding this comment.
Please retain this requested mapping but remove the unrelated snapshot entries from this PR. The current diff is +100/-1 and includes a separate existing-mapping replacement, despite the stated one-mapping scope.
|
The mappings from this PR are landing on main via #77132 as contributors/emails/ files, with credit — the AUTHOR_MAP dict this PR edits is frozen (per-email files are the conflict-free replacement; #77116 added scripts/audit_pr_attribution.py --fix to generate them automatically). Entries already mapped on main were skipped. Closing in favor of #77132 — thanks for keeping attribution clean. |
Consolidates the surviving mappings from PRs #53509 (@xqdwww), #29876 (@mihalyschroth), and #32842 (@vizicist, for @waefrebeorn's bounty account) into contributors/emails/ files — the frozen AUTHOR_MAP in release.py is not edited (the reason those PRs couldn't merge as-is). Entries from those PRs already present on main are skipped. All bare-noreply logins verified via the GitHub users API. Salvaged from @xqdwww (#53509), @mihalyschroth (#29876), @vizicist (#32842).
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww), NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's bounty account) into contributors/emails/ files — the frozen AUTHOR_MAP in release.py is not edited (the reason those PRs couldn't merge as-is). Entries from those PRs already present on main are skipped. All bare-noreply logins verified via the GitHub users API. Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876), @vizicist (NousResearch#32842).
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww), NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's bounty account) into contributors/emails/ files — the frozen AUTHOR_MAP in release.py is not edited (the reason those PRs couldn't merge as-is). Entries from those PRs already present on main are skipped. All bare-noreply logins verified via the GitHub users API. Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876), @vizicist (NousResearch#32842).
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww), NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's bounty account) into contributors/emails/ files — the frozen AUTHOR_MAP in release.py is not edited (the reason those PRs couldn't merge as-is). Entries from those PRs already present on main are skipped. All bare-noreply logins verified via the GitHub users API. Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876), @vizicist (NousResearch#32842).
Consolidates the surviving mappings from PRs NousResearch#53509 (@xqdwww), NousResearch#29876 (@mihalyschroth), and NousResearch#32842 (@vizicist, for @waefrebeorn's bounty account) into contributors/emails/ files — the frozen AUTHOR_MAP in release.py is not edited (the reason those PRs couldn't merge as-is). Entries from those PRs already present on main are skipped. All bare-noreply logins verified via the GitHub users API. Salvaged from @xqdwww (NousResearch#53509), @mihalyschroth (NousResearch#29876), @vizicist (NousResearch#32842).
Summary
mihaly.schroth@gmail.comtomihalyschroth.Test Plan
python3 -m py_compile scripts/release.pyscripts/release.pycontains the expectedAUTHOR_MAPentry.Scope