feat(kanban): auto-subscribe on CLI create from --subscribe-* args or env vars - #29840
Closed
crayfish-ai wants to merge 1 commit into
Closed
feat(kanban): auto-subscribe on CLI create from --subscribe-* args or env vars#29840crayfish-ai wants to merge 1 commit into
crayfish-ai wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this PR. The auto-subscribe feature will be submitted together with rerun_task and coder fixes as a single combined PR with 3 clean commits. |
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hermes kanban createdoes not auto-subscribe the creator to task notifications, whilehermes kanban createin gateway does. The CLI path lacks the_infer_subscribe_from_env()fallback that the gateway path has.Additionally, there is no way to explicitly subscribe on creation from the CLI without a separate
hermes kanban notify-subscribecall.Changes
_infer_subscribe_from_env()— new function that readsHERMES_NOTIFY_PLATFORM/HERMES_NOTIFY_CHAT_ID/HERMES_NOTIFY_THREAD_ID/HERMES_NOTIFY_USER_IDenv vars, used as a fallback when no explicit--subscribe-*args are given.--subscribe-platform,--subscribe-chat-id,--subscribe-thread-id,--subscribe-user-id— new CLI arguments onhermes kanban createfor explicit subscription.create_task()subscribe parameter —kanban_db.pynow accepts an optionalsubscribedict and atomically creates the notification subscription inside the same write transaction as the task row.Env var fallback — When neither explicit args nor
subscribeparam is provided, the function falls back toHERMES_NOTIFY_*env vars (matching the gateway path behavior).