Skip to content

fix(gateway): sync MEDIA regex extension allowlist with SUPPORTED_DOCUMENT_TYPES #29609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenglyes wants to merge 1 commit into from
Closed

fix(gateway): sync MEDIA regex extension allowlist with SUPPORTED_DOCUMENT_TYPES #29609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions gateway/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,9 +2158,24 @@ def extract_media(content: str) -> Tuple[List[Tuple[str, bool]], str]:

# Extract MEDIA:<path> tags, allowing optional whitespace after the colon
# and quoted/backticked paths for LLM-formatted outputs.
media_pattern = re.compile(
r'''[`"']?MEDIA:\s*(?P<path>`[^`\n]+`|"[^"\n]+"|'[^'\n]+'|(?:~/|/)\S+(?:[^\S\n]+\S+)*?\.(?:png|jpe?g|gif|webp|mp4|mov|avi|mkv|webm|ogg|opus|mp3|wav|m4a|flac|epub|pdf|zip|rar|7z|docx?|xlsx?|pptx?|txt|csv|apk|ipa)(?=[\s`"',;:)\]}]|$))[`"']?'''
# Build extension list from SUPPORTED_DOCUMENT_TYPES + known media types
# so the two stay in sync automatically.
_media_exts = set()
for ext in SUPPORTED_DOCUMENT_TYPES:
_media_exts.add(ext.lstrip("."))
_media_exts.update({"png", "jpg", "jpeg", "gif", "webp",
"mp4", "mov", "avi", "mkv", "webm",
"ogg", "opus", "mp3", "wav", "m4a", "flac",
"epub", "rar", "7z", "apk", "ipa", "markdown"})
_ext_list = sorted(_media_exts, key=lambda x: (-len(x), x))
_ext_pattern = "|".join(_ext_list)
_MEDIA_RE_STR = (
r'''[`"']?MEDIA:\s*(?P<path>'''
r'''`[^`\n]+`|"[^"\n]+"|'[^'\n]+'|'''
r'''(?:~/|/)\S+(?:[^\S\n]+\S+)*?\.(?:'''
+ _ext_pattern + r''')(?=[\s`"',;:)\]}]|$))[`"']?'''
)
media_pattern = re.compile(_MEDIA_RE_STR)
for match in media_pattern.finditer(content):
path = match.group("path").strip()
if len(path) >= 2 and path[0] == path[-1] and path[0] in "`\"'":
Expand Down