Skip to content

fix(hindsight): clear _session_turns after retain to stop transcript duplication #29555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndyZHENG0715 wants to merge 1 commit into from
Closed

fix(hindsight): clear _session_turns after retain to stop transcript duplication #29555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/memory/hindsight/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,6 +1489,10 @@ def _do_retain() -> None:
self._ensure_writer()
self._register_atexit()
self._retain_queue.put(_do_retain)
# Clear accumulated turns. The async writer captured a
# snapshot via closure at enqueue time. Without this
# _session_turns grows unbounded, causing duplication (#23724).
self._session_turns = []

def get_tool_schemas(self) -> List[Dict[str, Any]]:
if self._memory_mode == "context":
Expand Down