fix(slack): surface Block Kit content in fetched thread context - #29541
Closed
bpross wants to merge 3 commits into
Closed
fix(slack): surface Block Kit content in fetched thread context#29541bpross wants to merge 3 commits into
bpross wants to merge 3 commits into
Conversation
The Slack adapter's _fetch_thread_context only used msg.get("text") when
building the parent/sibling text for the thread-context cache. That field
typically contains just the alert title for bot-posted alerts (Honeycomb,
PagerDuty, Datadog, GitHub bot, etc.); the actionable payload --
"View graph"/"View incident" URLs, mrkdwn sections -- lives in `blocks`
and was dropped before reaching the agent. Replies in the thread had to
re-discover context the adapter already fetched, or fail when the URL was
the only useful signal.
The fix augments msg_text with three additions when `blocks` is present:
- _extract_text_from_slack_blocks() for rich_text content (forwarded
messages, quoted text).
- _serialize_slack_blocks_for_agent() for the JSON view of section /
actions / accessory blocks (already deliberately redacted; URLs
stripped on purpose to keep the payload compact and bounded).
- A new _extract_urls_from_slack_blocks() helper that walks the blocks
tree and emits the URLs the serializer omits. Buttons, link
accessories, and image_url/external_url fields are the targets.
Appended as `URLs: <comma-separated>` so the agent can see them
without parsing JSON.
The blocks-only path also moves the `if not msg_text: continue` guard
*after* the block extraction so a bot-posted parent that puts everything
in `blocks` and nothing in `text` is no longer silently dropped.
Tests:
- test_fetch_thread_context_extracts_block_kit_parent: bot parent with
title in `text` plus a button URL in `blocks`; asserts the URL surfaces
in the context string.
- test_fetch_thread_context_includes_blocks_only_parent: bot parent with
empty `text` and a URL embedded in mrkdwn; asserts the parent isn't
dropped and the URL surfaces.
Full slack test module: 277 passed, 0 regressions.
alt-glitch
added
type/bug
1 task
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for identifying the Block Kit-only parent case. The underlying defect remains on current main: plugins/platforms/slack/adapter.py:3788-3790 still drops historical messages with empty top-level text.
Problems
- The patch targets
gateway/platforms/slack.py, which was migrated toplugins/platforms/slack/adapter.pyby 5600105;git apply --checkconfirms the current patch does not apply. - Adding
_serialize_slack_blocks_for_agent()to historical context would permit up to 6,000 characters per message (plugins/platforms/slack/adapter.py:210-274) across the fetcher's 30-message default (:3692). Extract bounded display text and actionable URLs instead of attaching raw Block Kit JSON to every thread message. _fetch_thread_parent_text()still reads onlyparent.get("text")in its cold-cache fallback (:3891), so it needs the same renderer to preservereply_to_textparity.
Suggested changes
- Port the behavior into the bundled Slack plugin and share one bounded message renderer across live input, thread context, and parent lookup. The related #33469 discussion and linked shared-renderer work are relevant for covering attachment-only parents too.
Automated hermes-sweeper review.
| extras: list[str] = [] | ||
| rich_text = _extract_text_from_slack_blocks(blocks).strip() | ||
| if rich_text and rich_text not in msg_text: | ||
| extras.append(rich_text) |
Contributor
There was a problem hiding this comment.
Please avoid adding the 6,000-character JSON serializer to every historical message. _fetch_thread_context fetches up to 30 messages by default, so a direct port can place up to 180,000 characters of Block Kit payload into one thread prefill; extract bounded display text and actionable URLs instead.
teknium1
added
the
sweeper:blast-moderate
Port to plugins/platforms/slack/adapter.py after migration commit 5600105 deleted gateway/platforms/slack.py. Address hermes-sweeper review feedback: - Replace the full _serialize_slack_blocks_for_agent() JSON dump (up to 6000 chars/message × 30 messages = 180K chars) with a shared bounded _render_message_text() that extracts only display text and actionable URLs from section/header/context blocks plus rich_text and url keys. - Share _render_message_text() across _fetch_thread_context and _fetch_thread_parent_text cold-cache fallback so reply_to_text parity is preserved. - Add test_fetch_thread_parent_text_surfaces_block_urls for the cold-cache fallback path. Tests: 329 passed, 0 regressions across slack test modules.
teknium1
pushed a commit
that referenced
this pull request
Jul 22, 2026
Bot-posted alerts (Honeycomb, PagerDuty, Datadog, GitHub bot, etc.) carry
their actionable content — section text, button URLs — in Block Kit
blocks, while the plain text field holds only the alert title.
_fetch_thread_context and _fetch_thread_parent_text only read
msg.get('text'), so that content never reached the agent.
Add a _render_message_text helper that merges top-level text with
readable block content, section/header/context text, actionable URLs,
and (folded in from #61261 during conflict resolution) legacy
attachment fields, and use it for thread-context and parent-text
rendering.
Salvaged from #29541.
teknium1
added a commit
that referenced
this pull request
Jul 22, 2026
teknium1
pushed a commit
that referenced
this pull request
Jul 22, 2026
Bot-posted alerts (Honeycomb, PagerDuty, Datadog, GitHub bot, etc.) carry
their actionable content — section text, button URLs — in Block Kit
blocks, while the plain text field holds only the alert title.
_fetch_thread_context and _fetch_thread_parent_text only read
msg.get('text'), so that content never reached the agent.
Add a _render_message_text helper that merges top-level text with
readable block content, section/header/context text, actionable URLs,
and (folded in from #61261 during conflict resolution) legacy
attachment fields, and use it for thread-context and parent-text
rendering.
Salvaged from #29541.
teknium1
added a commit
that referenced
this pull request
Jul 22, 2026
Contributor
|
Merged via #69316 — your commit was cherry-picked onto current main with your authorship preserved in git history: your Thanks for the contribution! |
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
Bot-posted alerts (Honeycomb, PagerDuty, Datadog, GitHub bot, etc.) carry
their actionable content — section text, button URLs — in Block Kit
blocks, while the plain text field holds only the alert title.
_fetch_thread_context and _fetch_thread_parent_text only read
msg.get('text'), so that content never reached the agent.
Add a _render_message_text helper that merges top-level text with
readable block content, section/header/context text, actionable URLs,
and (folded in from NousResearch#61261 during conflict resolution) legacy
attachment fields, and use it for thread-context and parent-text
rendering.
Salvaged from NousResearch#29541.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlackAdapter._fetch_thread_contextonly readsmsg.get(\"text\")when building the thread parent / sibling text it passes to the agent. For bot-posted alerts (Honeycomb, PagerDuty, Datadog, GitHub bot, etc.) thetextfield is typically just the alert title; everything actionable -- the "View graph"/"View incident" URL, mrkdwn sections, threshold details -- lives inblocksand was dropped before reaching the agent.That meant an agent invoked by an @-mention in an alert thread couldn't see what the alert was about, even though the adapter had already fetched the full message. Replies had to re-discover context the adapter already had, or fail outright when the URL was the only useful signal.
What changes
In
_fetch_thread_context, when a message hasblocks, append three things tomsg_text(deduped against what's already there):_extract_text_from_slack_blocks()(forwarded/quoted messages)._serialize_slack_blocks_for_agent()(section / actions / accessory shape)._extract_urls_from_slack_blocks()helper. The existing serializer deliberately stripsurlto keep the payload bounded and avoid blanket exposure; this helper is the targeted opt-in for the call site that actually needs URLs, walkingurl/image_url/external_urlkeys across all elements. Emitted asURLs: <comma-separated>so the agent doesn't have to parse JSON.The
if not msg_text: continueguard moves after block extraction so a bot-posted parent that puts everything inblocksand nothing intextisn't silently dropped.No existing serialization semantics change:
_serialize_slack_blocks_for_agent's allowlist is untouched, so other paths that use it stay redacted.Tests
Two new tests in
TestSlackThreadContext:test_fetch_thread_context_extracts_block_kit_parent— bot parent with title intextplus a button URL inblocks; asserts the URL surfaces.test_fetch_thread_context_includes_blocks_only_parent— bot parent with emptytextand a URL embedded in mrkdwn; asserts the parent isn't dropped and the URL surfaces.Full slack test module run locally:
```
python -m pytest tests/gateway/test_slack_approval_buttons.py tests/gateway/test_slack.py tests/gateway/test_slack_mention.py tests/gateway/test_slack_channel_skills.py
```
277 passed, 0 regressions.
Test plan
_serialize_slack_blocks_for_agent's URL-stripping behavior on other paths