docs(skills): clarify external dir mutations (salvage of #29411) - #29444
Merged
kshitijk4poor merged 1 commit intoMay 20, 2026
Merged
Conversation
19 tasks
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #29411 onto current
main. Single docs-only commit, authorship preserved.What this fixes
The user-guide page
website/docs/user-guide/features/skills.mdstill claimed external skill directories were read-only:That hasn't been true since #17512 (commit
8c8fc6c1e, 2026-04-29), which removed the external-dir refusal fromskill_manageso thatpatch/edit/write_file/remove_file/deletemutate skills in place wherever they were discovered, including underskills.external_dirs. Behavior verified on currentmain:tools/skill_manager_tool.pyhas no external-dir refusal path; the only mutation guard is_pinned_guard(), and pin only protects deletion (fix(skills): pin protects against deletion only, not edits #20220).tests/tools/test_skill_manager_tool.pyhas theTestExternalSkillMutationsblock (test_patch_external_skill_writes_in_place,test_edit_external_skill_writes_in_place,test_write_file_on_external_skill,test_remove_file_on_external_skill) asserting in-place mutation.The stale docs invite users to point
external_dirsat shared/team/git-managed skill libraries assuming they're protected. Issue #25083 surfaced this mismatch; comment from @ntgussoni reports actually losing a skill directory this way.This PR is the smallest fix for the mismatch — it does not implement #25083 (per-skill
immutable: true). That feature is still open and the issue should remain open after this merges.Changes
External (read-only, shared)toExternal (shared, mutable if writable).Salvage details
e1458d495onto currentorigin/main(PR docs(skills): clarify external dir mutations #29411 was 21 commits behind, butgit log origin/main -- website/docs/user-guide/features/skills.mdshows no intervening churn — cherry-pick was clean, no conflicts).helix4u <4317663+helix4u@users.noreply.github.com>.Credit
All credit to @helix4u for catching the mismatch and writing the fix. Closes #29411.
Related: #25083 (still open —
immutable: truefeature request).