feat(kanban): surface task outcomes and blocked context - #29247
Conversation
|
@teknium1 I've updated my previous PR as you asked with the UI change on the kanban |
Restrict dashboard artifact paths to the task workspace before exposing or checking them, redact launcher exceptions, and add coverage for unsafe paths. Also maps the SatoDri noreply email for contributor attribution.
|
@teknium1 updated following salvage's tests |
|
Thanks for the rework @SatoDri — the summary-tree payload design is solid and the path allow-list on the open endpoint is competently scoped. Closing this one without merging, with reasoning so a resubmission lands cleanly. Three concerns:
What we'd merge: A re-scoped PR onto current Credit for the summary-tree design stays with you on the resubmission. (Salvage attempt #29274 closed unmerged for the same reasons.) |
Summary
Reopens the Kanban dashboard improvements from #25655 as a fresh branch against current
main, without replaying the stale old bundle wholesale.This updates the selected-task drawer/API so reviewers can see the useful task outcome information first:
Notes on the previous PR feedback
The old PR was closed because its
plugins/kanban/dashboard/dist/index.jswas stale against current main. This branch starts from currentorigin/mainand ports the behavior onto the current Kanban dashboard code, preserving newer scheduled/review/workflow/orchestration changes.I looked for a maintained Kanban source file under
web/src/plugins/kanban; this bundled dashboard plugin currently ships as a plain non-minified IIFE inplugins/kanban/dashboard/dist, so the frontend changes are applied there while keeping the diff focused.Test Plan
git diff --check -- plugins/kanban/dashboard/plugin_api.py plugins/kanban/dashboard/dist/index.js plugins/kanban/dashboard/dist/style.css tests/plugins/test_kanban_dashboard_plugin.pynode --check plugins/kanban/dashboard/dist/index.js$HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='— 102 passed$HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_kanban*.py tests/tools/test_kanban_tools.py -q -o 'addopts='— 620 passed, 1 skippednpm --prefix web cinpm --prefix web run buildAdditional check:
pytest tests/plugins -q -o 'addopts='currently reports 751 passed / 1 failed. The failure is unrelated to this diff:tests/plugins/web/test_web_search_provider_plugins.py::TestBundledPluginsRegister::test_all_seven_plugins_present_in_registryexpects seven web search providers, but current plugin discovery includesxaias an eighth provider.