You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maintenance update: I rebased/merged this PR locally against current main and resolved the conflict in agent/image_routing.py by preserving the current config-override-aware capability lookup while keeping the PR behavior: native-capable main models use native image parts before falling back to an explicit auxiliary vision backend for text-only/unknown models.\n\nValidation run locally after resolving conflicts:\n\nconsole\n$ .venv/bin/python -m pytest tests/agent/test_image_routing.py\n58 passed in 0.51s\n\n\nI attempted to push the conflict-resolution commit to the PR branch, but GitHub rejected the push because this token lacks the workflow scope and the fork needs to carry upstream workflow changes (remote error: refusing to allow an OAuth App to create or update workflow .github/workflows/docker-publish.yml without workflow scope). I will retry updating the branch when a workflow-scoped credential or maintainer-side branch update is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointP2Medium — degraded but workaround existstool/visionVision analysis and image generationtype/bugSomething isn't working
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent.image_input_mode: auto, prefer native image attachments when the active main model is known to support vision.auxiliary.visionas the fallback path for text-only or unknown main models.Fixes #29135
Test plan
/Users/cosmopolitan/.hermes/hermes-agent/venv/bin/python -m pytest -o 'addopts=' tests/agent/test_image_routing.py -qgit diff --check