Skip to content

fix: prefer native vision in auto image routing - #29138

Closed
cosmopolitan033 wants to merge 2 commits into
NousResearch:mainfrom
cosmopolitan033:fix/native-vision-auto-routing-29135
Closed

fix: prefer native vision in auto image routing#29138
cosmopolitan033 wants to merge 2 commits into
NousResearch:mainfrom
cosmopolitan033:fix/native-vision-auto-routing-29135

Conversation

@cosmopolitan033

Copy link
Copy Markdown

Summary

  • In agent.image_input_mode: auto, prefer native image attachments when the active main model is known to support vision.
  • Keep explicit auxiliary.vision as the fallback path for text-only or unknown main models.
  • Update image-routing tests to cover the mixed-profile case described in the issue.

Fixes #29135

Test plan

  • /Users/cosmopolitan/.hermes/hermes-agent/venv/bin/python -m pytest -o 'addopts=' tests/agent/test_image_routing.py -q
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint tool/vision Vision analysis and image generation labels May 20, 2026
@cosmopolitan033

Copy link
Copy Markdown
Author

Maintenance update: I rebased/merged this PR locally against current main and resolved the conflict in agent/image_routing.py by preserving the current config-override-aware capability lookup while keeping the PR behavior: native-capable main models use native image parts before falling back to an explicit auxiliary vision backend for text-only/unknown models.\n\nValidation run locally after resolving conflicts:\n\nconsole\n$ .venv/bin/python -m pytest tests/agent/test_image_routing.py\n58 passed in 0.51s\n\n\nI attempted to push the conflict-resolution commit to the PR branch, but GitHub rejected the push because this token lacks the workflow scope and the fork needs to carry upstream workflow changes (remote error: refusing to allow an OAuth App to create or update workflow .github/workflows/docker-publish.yml without workflow scope). I will retry updating the branch when a workflow-scoped credential or maintainer-side branch update is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image auto-routing cannot use native vision when auxiliary.vision is configured as fallback

2 participants