fix(i18n): make columnLabels.scheduled + columnHelp.scheduled optional - #29103
Closed
Ryan-Beahm wants to merge 1 commit into
Closed
fix(i18n): make columnLabels.scheduled + columnHelp.scheduled optional#29103Ryan-Beahm wants to merge 1 commit into
Ryan-Beahm wants to merge 1 commit into
Conversation
en.ts uses 'scheduled' in kanban columnLabels and columnHelp but the Translations interface in types.ts omits it, breaking 'npm run build' (tsc TS2353 'Object literal may only specify known properties' at en.ts lines 661 and 671). 'hermes dashboard' then fails to start. Marking the property optional (scheduled?: string) satisfies en.ts without forcing the 15 other untranslated locale files to add it. Build then succeeds and 'hermes dashboard --port N' binds cleanly. Repro before: cd web && npm run build -> TS2353 at en.ts:661,671 Verified: build passes (vite emits web_dist), dashboard HTTP 200. Signed-off-by: Ryan-Beahm <Rbeahm@outlook.com>
Collaborator
|
Duplicate of #28549 (merged 2026-05-19). That PR already added |
Contributor
|
This has already been fixed on main. Thanks for the concise report and the small targeted patch. Automated hermes-sweeper review evidence:
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/src/i18n/en.tsdeclaresscheduledkeys undercolumnLabelsandcolumnHelp(lines 661 and 671), but theTranslationsinterface inweb/src/i18n/types.tsdoesn't include them.tsc -b && vite build(which
hermes dashboardinvokes on launch) fails with TS2353:hermes dashboardthen exits before binding a port.Fix
Mark the property optional (
scheduled?: string) in bothcolumnLabelsand
columnHelp. This satisfiesen.tswithout forcing the 15 otheruntranslated locale files to add it. Once translations land in the other
locale files, the
?can be removed at the maintainer's discretion.Reproduce before
Verify after
Scope
web/src/i18n/types.ts).undefinedfor thescheduledcolumnlabel/help (graceful — same as any unset i18n key) instead of failing
the entire build.