fix(codex): gate unsupported reasoning fields - #29089
Open
offloadteam wants to merge 1 commit into
Open
Conversation
|
closed via automated cleanup |
teknium1
reviewed
Jun 15, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the narrow fix; the main-agent premise still reproduces on current main.
Problems
agent/transports/codex.py:184-186onorigin/mainunconditionally sendsreasoning={effort, summary}andinclude=["reasoning.encrypted_content"]for non-GitHub/non-xAI Codex Responses calls, so the reported payload bug is real.- The same bug class remains in the auxiliary Codex wrapper.
agent/auxiliary_client.py:697-727says it mirrorsagent/transports/codex.py::build_kwargs(), but it still always setsresp_kwargs["reasoning"]andresp_kwargs["include"] = ["reasoning.encrypted_content"]wheneverextra_body.reasoningis enabled.
Suggested changes
- Extract the capability gate into a shared helper and call it from both the main Codex transport and
CodexAuxiliaryClient, rather than adding a transport-only allowlist. - Add a regression test for the auxiliary path with a GPT-5 mini style model plus
extra_body.reasoning, asserting noreasoningand no encrypted reasoning include.
This is an automated hermes-sweeper review.
| kwargs["reasoning"] = {"effort": reasoning_effort, "summary": "auto"} | ||
| kwargs["include"] = ["reasoning.encrypted_content"] | ||
| model_name = str(model or "").lower().rsplit("/", 1)[-1] | ||
| supports_encrypted_reasoning = ( |
Contributor
There was a problem hiding this comment.
Please make this capability gate shared rather than transport-local. agent/auxiliary_client.py:697-727 mirrors this Codex kwargs logic and still unconditionally emits reasoning plus encrypted include, so fixing only this branch leaves a sibling Codex Responses path with the same bug class.
Contributor
|
Thanks for the focused payload guard. The main-agent premise remains present on current main. Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Notes
This is the narrow upstreamable slice from a production Garagebox runtime patch. Diagnostic sentinel and terminal-helper timeout changes were intentionally not included because they need separate design/review.