Skip to content

docs(curator): align 'agent-created' definition with actual provenance semantics - #29018

Closed
Twanislas wants to merge 1 commit into
NousResearch:mainfrom
Twanislas:docs/fix-curator-agent-created-definition
Closed

docs(curator): align 'agent-created' definition with actual provenance semantics#29018
Twanislas wants to merge 1 commit into
NousResearch:mainfrom
Twanislas:docs/fix-curator-agent-created-definition

Conversation

@Twanislas

Copy link
Copy Markdown
Contributor

Summary

The curator docs stated that any skill not bundled/hub-installed was "agent-created" — including foreground-created skills and hand-written ones. Since PR #19621, the curator requires an explicit created_by: "agent" marker in .usage.json, which only the background self-improvement review fork sets.

Closes #29017.

Changes

1. Rewrite "What agent-created means" section

Before (stale): claimed all non-bundled/non-hub skills were curated — including foreground skill_manage(create) calls and hand-written skills.

After: documents the actual 3-step eligibility check:

  1. Not bundled
  2. Not hub-installed
  3. created_by: "agent" or agent_created: true in .usage.json

Explains that only the background review fork sets this marker, and that foreground-created skills are intentionally excluded (user-directed by design). Warns that hand-written skills are NOT curated.

2. Add note on (not resolved) display in reports

When no agent-created candidates exist, the LLM pass is skipped and the report shows Model: (not resolved) via (not resolved) with Duration: 0s. This is expected behavior, not a config error. Added a :::note callout in the Per-run reports section.

3. Link to provenance internals

References tools/skill_provenance.py (write-origin ContextVar) and mark_agent_created() so users who want to understand the mechanism can trace the code.

Files changed

  • website/docs/user-guide/features/curator.md: +45 −21 lines

Verification

No code changes — docs only. The provenance semantics described match the current behavior in:

  • tools/skill_provenance.pyBACKGROUND_REVIEW ContextVar, is_background_review()
  • tools/skill_manager_tool.pymark_agent_created() gate at line 782
  • tools/skill_usage.py_is_curator_managed_record(), list_agent_created_skill_names()

…e semantics

The curator docs stated that any skill not bundled/hub-installed was
'agent-created' and subject to curation — including foreground-created
skills and hand-written ones. Since PR NousResearch#19621 (May 2026), the curator
requires an explicit  marker in .usage.json, which
only the background self-improvement review fork sets.

Changes:
- Rewrite 'What agent-created means' to document the 3-step eligibility
  check (not bundled + not hub + created_by=agent marker)
- Explain that foreground skill_manage(create) does NOT mark skills as
  agent-created (user-directed by design)
- Warn that hand-written skills are NOT curated
- Add note in Per-run reports explaining the '(not resolved)' display
  when no candidates exist (LLM pass skipped, not a config error)
- Link to skill_provenance.py for the write-origin ContextVar

Ref: PR NousResearch#19621, tools/skill_provenance.py, tools/skill_manager_tool.py
@alt-glitch alt-glitch added type/docs Documentation improvements tool/skills Skills system (list, view, manage) P3 Low — cosmetic, nice to have labels May 20, 2026
@teknium1

Copy link
Copy Markdown
Contributor

This docs update is already present on current main, so I'm closing this as implemented. This is an automated hermes-sweeper review.

Evidence:

  • website/docs/user-guide/features/curator.md:137 now documents the explicit .usage.json eligibility check, including created_by: "agent" / agent_created: true.
  • website/docs/user-guide/features/curator.md:151 explains that foreground-created skills are user-directed and not curator-managed; website/docs/user-guide/features/curator.md:155 covers hand-written skills.
  • website/docs/user-guide/features/curator.md:241 documents the expected (not resolved) report display when there are no candidates.
  • The implementation matches the docs: tools/skill_usage.py:449 checks the provenance marker, and tools/skill_manager_tool.py:967 only marks creates from the background review fork.
  • Shipped on main in 549a69a925a799001cab63a4244b8e486c8c2ab4, which is contained in v2026.6.5.

@teknium1 teknium1 closed this Jun 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main tool/skills Skills system (list, view, manage) type/docs Documentation improvements

Projects

None yet

3 participants