Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gateway/platforms/qqbot/adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,8 @@ async def _read_events(self) -> None:
"""Read WebSocket frames until connection closes."""
if not self._ws:
raise RuntimeError("WebSocket not connected")
if self._ws.closed:
raise RuntimeError("WebSocket closed")

while self._running and self._ws and not self._ws.closed:
msg = await self._ws.receive()
Expand Down
1 change: 1 addition & 0 deletions scripts/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,7 @@
"120500656+oooindefatigable@users.noreply.github.com": "ooovenenoso",
"vanthinh6886@gmail.com": "vanthinh6886", # PR #28018 salvage (yaml/flock/atomic write guards)
"erik.engervall@gmail.com": "erikengervall", # PR #28774 (firecrawl integration tag)
"win847@users.noreply.github.com": "win847",
}


Expand Down
27 changes: 27 additions & 0 deletions tests/gateway/test_qqbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,33 @@ def test_message_format(self):
assert "rate limit" in str(err)


# ---------------------------------------------------------------------------
# _read_events
# ---------------------------------------------------------------------------

class TestQQReadEvents:
"""Tests for QQAdapter._read_events()."""

@pytest.mark.asyncio
async def test_raises_on_closed_ws(self):
"""When self._ws.closed is True, _read_events should raise RuntimeError,
preventing the caller from silently resetting backoff_idx."""
from gateway.platforms.qqbot import QQAdapter
adapter = QQAdapter(_make_config(app_id="a", client_secret="b"))
adapter._ws = SimpleNamespace(closed=True)
with pytest.raises(RuntimeError, match="WebSocket closed"):
await adapter._read_events()

@pytest.mark.asyncio
async def test_raises_on_missing_ws(self):
"""When self._ws is None, _read_events should raise RuntimeError."""
from gateway.platforms.qqbot import QQAdapter
adapter = QQAdapter(_make_config(app_id="a", client_secret="b"))
adapter._ws = None
with pytest.raises(RuntimeError, match="WebSocket not connected"):
await adapter._read_events()


# ---------------------------------------------------------------------------
# _dispatch_payload
# ---------------------------------------------------------------------------
Expand Down