fix(gateway): merge Portal API free recommendations into /model picker - #28931
fix(gateway): merge Portal API free recommendations into /model picker#28931LifeJiggy wants to merge 1 commit into
Conversation
43037a5 to
70599e2
Compare
|
@alt-glitch Instead of tier detection + conditional calls (check_nous_free_tier → union_with_portal_free_recommendations or union_with_portal_paid_recommendations), this adds a new combined helper union_with_portal_recommendations() that calls the Portal endpoint once and merges both freeRecommendedModels and paidRecommendedModels in a single pass. Net result: same coverage as #26910 but in 1 API call instead of 2-3, no tier detection, no branching. Happy to coordinate — either approach solves the issue. Mine trades a slightly larger helper function for fewer API calls/simpler call-site logic; #26910 reuses existing per-tier helpers. Let us know which direction you prefer. |
…l picker list_authenticated_providers() only loaded the curated (paid) model list for Nous Portal, so the gateway /model picker never showed free models like deepseek-v4-flash and stepfun/step-3.5-flash. Adds union_with_portal_recommendations() — a single-call combined helper that fetches the /api/nous/recommended-models endpoint ONCE and merges BOTH freeRecommendedModels and paidRecommendedModels into the curated list. This avoids the multi-call tier-detection pattern (check_nous_free_tier + conditional union_with_portal_free/paid_recommendations) used elsewhere. The CLI hermes model command already handles Portal recommendations via the separate helpers; this fix brings the same coverage to the shared list_authenticated_providers() used by the gateway, in fewer API calls.
70599e2 to
e382d57
Compare
|
@teknium1 PTAL |
|
This is implemented on current main. Automated hermes-sweeper review found the gateway
This also matches the linked discussion: issue #28886 was already closed as implemented on main, and competing PR #26910 was closed after the behavior was present. |
Summary
The gateway
/modelpicker only uses the staticmodel-catalog.jsonfor theNous Portal provider, missing dynamically-recommended models like DeepSeek V4
Flash (announced May 14 via Novita Labs promotion). The interactive CLI already
calls
union_with_portal_free_recommendations()— this teacheslist_authenticated_providers()(used by the gateway) to do the same.Related Issue
Fixes #28886
Type of Change
Changes Made
hermes_cli/model_switch.py:1169-1180— afterget_curated_nous_model_ids(),call
union_with_portal_free_recommendations()to merge Portal APIfreeRecommendedModelsinto the nous provider's curated list. Falls backto the curated list on any error (silent degrade).
How to Test
hermes login nous)/modelvia Discord or Telegram gateway