fix(whatsapp): forward quotedMessageId/context to agent prompt - #28878
Closed
Shizoqua wants to merge 1 commit into
Closed
fix(whatsapp): forward quotedMessageId/context to agent prompt#28878Shizoqua wants to merge 1 commit into
Shizoqua wants to merge 1 commit into
Conversation
The WhatsApp bridge (PR NousResearch#25489) already extracts quotedMessageId, quotedParticipant, quotedRemoteJid, and hasQuotedMessage from Baileys' contextInfo, but the adapter in gateway/platforms/whatsapp.py only used quotedParticipant for admission control. The remaining fields were dropped, so reply-based corrections in WhatsApp lost all context — the agent only saw the new reply text with no reference to the quoted message. This forwards the quoted-message context to the agent using the same shape as the Matrix adapter (see NousResearch#27946 fix), keeping cross-platform behavior consistent. Non-reply messages are unchanged. Fixes NousResearch#28823
alt-glitch
added
type/bug
teknium1
reviewed
Jun 15, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on. The underlying bug is real on current main, but this patch only carries the quoted message id; the gateway prompt path still needs quoted text before the agent sees useful reply context.
Problems
gateway/platforms/whatsapp.py:1166-1174on current main drops quoted metadata when constructingMessageEvent, so the premise is valid.gateway/run.py:8048-8056only injects reply context into the prompt when bothevent.reply_to_textandevent.reply_to_message_idare set.- This PR's new test at
tests/gateway/test_whatsapp_formatting.py:350-351verifiesreply_to_message_id == "ABC123"whilereply_to_text is None, so the existing prompt injection guard would still skip the[Replying to: ...]prefix.
Suggested changes
- Have
scripts/whatsapp-bridge/bridge.jsextract aquotedTextvalue from BaileyscontextInfo.quotedMessageand include it in the bridge payload. - Map that field to
MessageEvent.reply_to_textingateway/platforms/whatsapp.py. - Add a regression that runs through
GatewayRunner._prepare_inbound_message_textand proves WhatsApp replies produce the visible[Replying to: "..."]prompt prefix.
Automated hermes-sweeper review.
| message_id=data.get("messageId"), | ||
| media_urls=cached_urls, | ||
| media_types=media_types, | ||
| reply_to_message_id=reply_to_message_id, |
Contributor
There was a problem hiding this comment.
Setting only reply_to_message_id does not make the quoted context visible to the agent: gateway/run.py injects the reply prefix only when reply_to_text is also present. This needs the bridge to send quoted text and the adapter to populate MessageEvent.reply_to_text as well.
|
|
||
| assert event is not None | ||
| assert event.reply_to_message_id == "ABC123" | ||
| assert event.reply_to_text is None # bridge doesn't emit quoted text yet |
Contributor
There was a problem hiding this comment.
This assertion locks in the incomplete behavior. A regression for the reported bug should prove the quoted body reaches the prompt, e.g. by feeding the event through _prepare_inbound_message_text and checking for the [Replying to: "..."] prefix.
Contributor
|
Implemented on current main. This is an automated hermes-sweeper review.
This also resolves the missing-quoted-text concern raised in the prior review and the adapter gap documented in #28823. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WhatsApp bridge (PR #25489) already extracts quotedMessageId, quotedParticipant, quotedRemoteJid, and hasQuotedMessage from Baileys' contextInfo, but the adapter in gateway/platforms/whatsapp.py only used quotedParticipant for admission control. The remaining fields were dropped, so reply-based corrections in WhatsApp lost all context — the agent only saw the new reply text with no reference to the quoted message.
This forwards the quoted-message context to the agent using the same shape as the Matrix adapter (see #27946 fix), keeping cross-platform behavior consistent. Non-reply messages are unchanged.
Fixes #28823