-
Notifications
You must be signed in to change notification settings - Fork 52.3k
fix(kanban): pass skills from decomposer to child tasks #28875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
szocpaul
wants to merge
1
commit into
NousResearch:main
Choose a base branch
from
szocpaul:fix/kanban-decompose-skills
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,8 @@ | |
| "title": "<concrete task title, imperative voice, <= 80 chars>", | ||
| "body": "<detailed spec for the worker on this child task>", | ||
| "assignee": "<profile name from the roster, or null for default>", | ||
| "parents": [<int>, ...] | ||
| "parents": [<int>, ...], | ||
| "skills": ["<skill-name>", ...] # optional — skill bundles to force-load | ||
| }, | ||
| ... | ||
| ] | ||
|
|
@@ -89,6 +90,9 @@ | |
| and the system will route to the default_assignee. | ||
| - Each child task body is what a fresh worker will read with no other | ||
| context — be specific about goal, approach, and acceptance criteria. | ||
| - Use "skills" to specify skill bundles the worker should force-load | ||
| (e.g. ["github-workflow", "test-driven-development"]). Omit if no | ||
| special skills are needed. | ||
|
|
||
| When the task is genuinely a single unit of work (no useful decomposition), | ||
| return: | ||
|
|
@@ -431,11 +435,18 @@ def decompose_task( | |
| parents = [] | ||
| # Clean parent indices: drop non-int and out-of-range. | ||
| clean_parents = [p for p in parents if isinstance(p, int) and 0 <= p < len(raw_tasks) and p != idx] | ||
| # Extract optional skills list from the decomposer response. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This keeps the original string rather than s.strip(), so a decomposer response like " translation " would persist a skill name with spaces unless the DB layer normalizes it later. |
||
| raw_skills = entry.get("skills") | ||
| if isinstance(raw_skills, list): | ||
| skills_list = [s for s in raw_skills if isinstance(s, str) and s.strip()] | ||
| else: | ||
| skills_list = [] | ||
| children.append({ | ||
| "title": title.strip()[:200], | ||
| "body": body.strip(), | ||
| "assignee": chosen, | ||
| "parents": clean_parents, | ||
| "skills": skills_list, | ||
| }) | ||
|
|
||
| try: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should mirror create_task's skills normalization: strip the stored value, dedupe, reject comma-containing names, and reject known toolset names so decomposed children behave like tasks created through the normal path.