feat(firecrawl): add integration tag for Hermes usage (pending telemetry opt-in) - #28865
Closed
teknium1 wants to merge 1 commit into
Closed
feat(firecrawl): add integration tag for Hermes usage (pending telemetry opt-in)#28865teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
23 tasks
Contributor
🔎 Lint report:
|
Contributor
Author
|
Closing per telemetry policy — we don't merge new outbound usage-attribution tags until a generic user-facing opt-in gate exists (config gate + setup prompt + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens the change from #28774 (originally by @erikengervall, merged then reverted in #28862) as a tracking PR.
Original commit cherry-picked with authorship preserved.
Why this is parked, not merged
The change tags every Firecrawl API call with
integration: "hermes"so Firecrawl can attribute usage back to us. It is well-intentioned and harmless on its own, but it is outbound third-party usage attribution — a form of telemetry — and Hermes does not currently have a user-facing opt-in mechanism for any outbound telemetry / attribution / analytics.Our standing policy: we are not adding any more outbound telemetry than what is strictly required for a feature to function, until we land a generic opt-in gating mechanism (config gate + setup wizard prompt + clear user-facing toggle).
What needs to happen before merge
telemetry.attribution: falsedefault, prompted duringhermes setup, exposed inhermes tools).integrationfield when the user has opted in.Tracking under the
telemetrylabel so we can find this when the gating infra lands.Validation
Same change as #28774; no new code paths beyond the cherry-pick. Will need to be rebased + gated before it can ship.