Skip to content

feat(firecrawl): add integration tag for Hermes usage (pending telemetry opt-in) - #28865

Closed
teknium1 wants to merge 1 commit into
mainfrom
hermes/firecrawl-integration-tag-telemetry-gated
Closed

feat(firecrawl): add integration tag for Hermes usage (pending telemetry opt-in)#28865
teknium1 wants to merge 1 commit into
mainfrom
hermes/firecrawl-integration-tag-telemetry-gated

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Re-opens the change from #28774 (originally by @erikengervall, merged then reverted in #28862) as a tracking PR.

Original commit cherry-picked with authorship preserved.

Why this is parked, not merged

The change tags every Firecrawl API call with integration: "hermes" so Firecrawl can attribute usage back to us. It is well-intentioned and harmless on its own, but it is outbound third-party usage attribution — a form of telemetry — and Hermes does not currently have a user-facing opt-in mechanism for any outbound telemetry / attribution / analytics.

Our standing policy: we are not adding any more outbound telemetry than what is strictly required for a feature to function, until we land a generic opt-in gating mechanism (config gate + setup wizard prompt + clear user-facing toggle).

What needs to happen before merge

  1. A general opt-in telemetry gate (e.g. telemetry.attribution: false default, prompted during hermes setup, exposed in hermes tools).
  2. This PR updated so both Firecrawl call sites read that gate and only send the integration field when the user has opted in.
  3. Docs updated to disclose what is sent, to whom, and how to disable.

Tracking under the telemetry label so we can find this when the gating infra lands.

Validation

Same change as #28774; no new code paths beyond the cherry-pick. Will need to be rebased + gated before it can ship.

@teknium1 teknium1 added the telemetry Touches outbound telemetry, usage attribution, or analytics — needs opt-in gating before merge label May 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/firecrawl-integration-tag-telemetry-gated vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8963 on HEAD, 8963 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4719 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/feature New feature or request comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels May 19, 2026
@teknium1

teknium1 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing per telemetry policy — we don't merge new outbound usage-attribution tags until a generic user-facing opt-in gate exists (config gate + setup prompt + hermes tools toggle). Parked behind the telemetry label; revisit once the opt-in mechanism lands.

@teknium1 teknium1 closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have telemetry Touches outbound telemetry, usage attribution, or analytics — needs opt-in gating before merge type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants