fix(install.ps1): remove UTF-8 BOM that breaks irm | iex path - #28732
Closed
LifeJiggy wants to merge 1 commit into
Closed
fix(install.ps1): remove UTF-8 BOM that breaks irm | iex path#28732LifeJiggy wants to merge 1 commit into
LifeJiggy wants to merge 1 commit into
Conversation
The UTF-8 BOM (EF BB BF) at byte 0 causes [scriptblock]::Create to fail with 'The assignment expression is not valid' on param defaults, breaking the canonical 'irm ... | iex' one-liner for Windows installation. PowerShell's normal file-execution path (& .\install.ps1) handles BOMs fine regardless, but the irm-and-iex path uses [scriptblock]::Create which does NOT strip BOMs. Since the file contains no non-ASCII characters, the BOM is unnecessary for PS 5.1 parsing. Fixes NousResearch#28071.
Collaborator
|
Duplicate — #28169 (merged 2026-05-19) already stripped the BOM from install.ps1 and added -Commit/-Tag pin params. This PR's change is already in main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix(install.ps1): remove UTF-8 BOM that breaks irm | iex path
What does this PR do?
The UTF-8 BOM (EF BB BF) at byte 0 of
scripts/install.ps1causes[scriptblock]::Createto fail with'The assignment expression is not valid'on param defaults, breaking the canonicalirm https://... | iexone-liner for Windows installation.PowerShell's normal file-execution path (
& .\install.ps1) handles BOMs fine, but theirm-and-iexpath uses[scriptblock]::Create((irm ...))which does NOT strip BOMs — the BOM lands inside theparam()block and corrupts the parser state. Since the file contains no non-ASCII characters, the BOM is unnecessary for PS 5.1 parsing.Related Issue
Fixes #28071
Type of Change
Changes Made
scripts/install.ps1: Removed the 3-byte UTF-8 BOM prefix (byte 0xEF 0xBB 0xBF)How to Test
irm https://raw.githubusercontent.com/LifeJiggy/hermes-agent/fix/install-ps1-bom/scripts/install.ps1 | iexThe assignment expression is not valid& .\scripts\install.ps1still works for local executionChecklist
Code
pytest tests/ -qand all tests passDocumentation & Housekeeping