fix(memory): label recalled memory as informational, not authoritative (#28001) - #28583
Merged
Conversation
…e_file Adds TestGitBaselineCheck with 6 unit tests covering _check_git_baseline and the warning field in write_file result: - Git not available → None - Not in a git repo → None - Clean repo → None - Dirty repo → returns warning string with branch name - write_file result includes warning when dirty - write_file result omits warning when clean
1 task
Contributor
🔎 Lint report:
|
alt-glitch
added
type/bug
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #28001 by @LifeJiggy.
What: The system note wrapping recalled memory said "Treat as authoritative reference data — this is the agent's persistent memory and should inform all responses." Calling stale memory "authoritative" overrides the model's own judgment when memory contradicts current reality, e.g. cached project structure that's since been refactored.
How:
agent/memory_manager.py: rewrite the system-note text to "Treat as informational background data (may be stale)" with the same "should inform all responses" guidance._INTERNAL_NOTE_REso the new and old forms both get stripped on round-trip (prevents the note from leaking into history).ShellFileOperations._check_git_baseline(a related test gap the author noticed while in the area).Original PR: #28001
Fixes #17164.