docs(skills/darwinian-evolver): add pickle security note to SKILL.md - #28564
Open
Bihruze wants to merge 1 commit into
Open
docs(skills/darwinian-evolver): add pickle security note to SKILL.md#28564Bihruze wants to merge 1 commit into
Bihruze wants to merge 1 commit into
Conversation
Adds explicit security warning about pickle deserialization risk for snapshots. Raised by @123mikeyd in Discord.
teknium1
reviewed
Jun 15, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused security docs follow-up. The premise still holds on current main: SKILL.md mentions pickle snapshots at optional-skills/research/darwinian-evolver/SKILL.md:84 and nested pickles at optional-skills/research/darwinian-evolver/SKILL.md:169-171, but it does not explicitly warn about pickle RCE.
Problems
- Current main has since added a runtime acknowledgement gate in optional-skills/research/darwinian-evolver/scripts/show_snapshot.py:29-35 and refuses to unpickle without it at optional-skills/research/darwinian-evolver/scripts/show_snapshot.py:42-48. The SKILL.md quick-start command at optional-skills/research/darwinian-evolver/SKILL.md:109-111 still omits
--i-trust-this-file, so applying this docs warning alone would leave the example stale.
Suggested changes
- Keep the new
## Securitysection, and also update theshow_snapshot.pyinvocation in SKILL.md to include--i-trust-this-fileso the warning and the runnable example line up with current main.
Automated hermes-sweeper review.
| ``` | ||
| ## Security | ||
|
|
||
| ⚠️ **Pickle deserialization risk.** Snapshots produced by `darwinian_evolver` are Python pickle files. Loading a pickle from an untrusted source can execute arbitrary code on your machine. |
Contributor
There was a problem hiding this comment.
This warning is accurate. If this is salvaged onto current main, please also update the earlier show_snapshot.py example to pass --i-trust-this-file, because the script now refuses to unpickle without that acknowledgement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small follow-up to #26760. Adds an explicit security note to
SKILL.mdabout the pickle deserialization risk for snapshots produced bydarwinian_evolver.The Pitfalls section in the merged version mentions nested-pickle snapshots as a structural quirk, but doesn't flag the underlying arbitrary-code-execution risk. This PR makes that explicit so users know not to load snapshots from untrusted sources.
Raised by @123mikeyd in Discord — credit to them for the catch.
Related Issue
Follow-up to #26760 (no separate issue).
Type of Change
Changes Made
optional-skills/research/darwinian-evolver/SKILL.md: added a new## Securitysection warning users about pickle deserialization risk and recommending they only load snapshots from trusted sources.How to Test
Docs-only change, no runtime behavior affected.
optional-skills/research/darwinian-evolver/SKILL.md## Securitysection renders correctly and the warning is clear.Checklist
Code
docs(scope):)pytest tests/ -qand all tests pass — N/A (docs-only)Documentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AScreenshots / Logs
N/A — docs-only change.