fix(gateway): close /proc cmdline file handle in PID scan loop - #28472
Closed
annguyenNous wants to merge 1 commit into
Closed
fix(gateway): close /proc cmdline file handle in PID scan loop#28472annguyenNous wants to merge 1 commit into
annguyenNous wants to merge 1 commit into
Conversation
The /proc scanning loop opened /proc/{pid}/cmdline for every numeric
PID entry without closing the file handle. On busy systems with
hundreds of PIDs, this leaks file descriptors until GC runs.
Use a with-statement to ensure deterministic cleanup.
Signed-off-by: annguyenNous <annguyenNous@users.noreply.github.com>
Collaborator
Contributor
|
Thanks for the focused resource-leak cleanup. An automated hermes-sweeper review found that this exact fix is already present on current main, so I’m closing this as Evidence:
The prior duplicate note linking this to the same leak pattern as #27910 was useful context; the current main code now covers this PR’s requested behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_find_gateway_pids_by_profile()inhermes_cli/gateway.pyopens/proc/{pid}/cmdlinefor every numeric PID entry without closing the file handle. On busy systems with hundreds of PIDs, this leaks file descriptors.Fix
Use a
withstatement for deterministic cleanup: