fix(tests): unblock kanban diagnostics + compression boundary - #28466
Closed
felix-windsor wants to merge 1 commit into
Closed
fix(tests): unblock kanban diagnostics + compression boundary#28466felix-windsor wants to merge 1 commit into
felix-windsor wants to merge 1 commit into
Conversation
alt-glitch
added
type/test
Collaborator
|
Superseded by #28465 (merged) which fixes the same kanban diagnostics severity filter and compression boundary test failures. Both PRs address the same stale tests from the same recent merges. |
Contributor
Author
|
Closing as superseded by #28465 (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_last_compress_abortedsentinels as a hard abort (MagicMock truthiness) so compression boundary tests exercise the intended path.Tests
./scripts/run_tests.sh tests/plugins/test_kanban_dashboard_plugin.py::test_diagnostics_endpoint_severity_filter tests/run_agent/test_compression_boundary_hook.py./.venv/bin/ruff check agent/conversation_compression.py plugins/kanban/dashboard/plugin_api.pyNotes: There is already an open PR for the separate
/compress force=test stub drift (#28303); this PR stays scoped to the kanban + compression-boundary failures.