[TSA-98] Cover Telegram clarify choice buttons - #28259
Closed
junaidnasir wants to merge 1 commit into
Closed
Conversation
junaidnasir
force-pushed
the
linear/TSA-98-telegram-clarify-buttons
branch
from
May 19, 2026 00:09
fe8b24e to
caf38fd
Compare
Contributor
|
Closing — your PR is tests-only against an implementation that doesn't exist yet on The actual fix is being merged via salvage of #27852 (renders full text in body, short numeric button labels). Once that lands, your test coverage approach (testing the cl: callback dispatch path) would be a useful follow-up — feel free to re-open against current main after #27852 merges if you'd like to expand the coverage. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/main, which already contains the Telegram clarify-button implementation viatools.clarify_gateway,BasePlatformAdapter.send_clarify, andTelegramAdapter.send_clarify/cl:callbacks.tools.clarify_gateway,Other (type answer)entering text-capture mode,Test plan
python -m pytest tests/gateway/test_telegram_approval_buttons.py -q→ 22 passedpython -m pytest tests/gateway/test_telegram*.py -q→ 434 passedRefs TSA-98
https://linear.app/tsaur/issue/TSA-98/use-telegram-clickable-options-for-choice-based-agent-questions