Skip to content

[TSA-98] Cover Telegram clarify choice buttons - #28259

Closed
junaidnasir wants to merge 1 commit into
NousResearch:mainfrom
junaidnasir:linear/TSA-98-telegram-clarify-buttons
Closed

[TSA-98] Cover Telegram clarify choice buttons#28259
junaidnasir wants to merge 1 commit into
NousResearch:mainfrom
junaidnasir:linear/TSA-98-telegram-clarify-buttons

Conversation

@junaidnasir

@junaidnasir junaidnasir commented May 19, 2026

Copy link
Copy Markdown

Summary

  • Rebases TSA-98 work onto current origin/main, which already contains the Telegram clarify-button implementation via tools.clarify_gateway, BasePlatformAdapter.send_clarify, and TelegramAdapter.send_clarify / cl: callbacks.
  • Adds focused Telegram regression coverage for:
    • rendering clarify choices as inline keyboard buttons,
    • resolving a selected choice through tools.clarify_gateway,
    • Other (type answer) entering text-capture mode,
    • unauthorized users being rejected.

Test plan

  • python -m pytest tests/gateway/test_telegram_approval_buttons.py -q → 22 passed
  • python -m pytest tests/gateway/test_telegram*.py -q → 434 passed

Refs TSA-98
https://linear.app/tsaur/issue/TSA-98/use-telegram-clickable-options-for-choice-based-agent-questions

@junaidnasir
junaidnasir force-pushed the linear/TSA-98-telegram-clarify-buttons branch from fe8b24e to caf38fd Compare May 19, 2026 00:09
@junaidnasir junaidnasir changed the title [TSA-98] Add Telegram clarify choice buttons [TSA-98] Cover Telegram clarify choice buttons May 19, 2026
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have platform/telegram Telegram bot adapter comp/gateway Gateway runner, session dispatch, delivery labels May 19, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Closing — your PR is tests-only against an implementation that doesn't exist yet on origin/main (the production send_clarify still truncates labels to 60 chars and renders no body text). The body refers to tools.clarify_gateway clarify-button infrastructure as if it were already merged.

The actual fix is being merged via salvage of #27852 (renders full text in body, short numeric button labels). Once that lands, your test coverage approach (testing the cl: callback dispatch path) would be a useful follow-up — feel free to re-open against current main after #27852 merges if you'd like to expand the coverage. Thanks.

@teknium1 teknium1 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/telegram Telegram bot adapter type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants