fix(kanban-dashboard): make Orchestration mode checkbox label static - #28258
Closed
maxmilian wants to merge 1 commit into
Closed
fix(kanban-dashboard): make Orchestration mode checkbox label static#28258maxmilian wants to merge 1 commit into
maxmilian wants to merge 1 commit into
Conversation
The checkbox label echoed its state ("Auto (default)" / "Manual") instead
of describing the action, so a checked box reading "Auto" parsed as a
status indicator rather than a control. The accompanying sub-description
was also static and started with "When on, ...", which read awkwardly
when the box was unchecked.
Replace the dynamic label with a static action label
("Auto-decompose triage tasks") and flip the sub-description between the
two modes so it stays accurate either way. The top-of-page Orchestration
pill is unchanged — that one is intentionally a status badge / toggle.
Fixes NousResearch#28178
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alt-glitch
added
type/bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28178. The kanban board's Orchestration mode checkbox label echoed its own state ("Auto (default)" / "Manual") instead of describing the action it controls, which inverts the usual convention that a checkbox label describes what happens when checked.
Root cause
plugins/kanban/dashboard/dist/index.js:1591:The ternary on
settings.auto_decomposemade the label a state mirror. The sub-description on the next line was also static and began with"When on, ...", which reads awkwardly when the box is unchecked.Fix
"Auto-decompose triage tasks"(matches the reporter's suggestion)."The dispatcher decomposes new triage tasks automatically."vs"Triage tasks stay in triage until you click ⚗ Decompose.") so it stays accurate either way. The "Manual" copy mirrors the existing language already used elsewhere (plugins/kanban/dashboard/dist/index.js:1495andwebsite/docs/user-guide/features/kanban.md:447).Net diff: +4 / -2 in the dist bundle.
Tests
No automated tests for the dashboard plugin's rendered text. Verified:
node --check plugins/kanban/dashboard/dist/index.js— parses clean."Manual"occurrence in this file is the top-of-page Orchestration: Auto/Manual pill (:1512), which intentionally doubles as a status badge / toggle and is documented that way; it is left unchanged.Scope
Intentionally not touching:
"Orchestration mode"section label above the checkbox — unrelated, reads as a settings group title.dist/index.jsfollows the established convention.