Skip to content

fix: recognize emoji and caret as natural response endings #28168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oseftg wants to merge 1 commit into from
Closed

fix: recognize emoji and caret as natural response endings #28168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,15 @@ def _has_natural_response_ending(content: str) -> bool:
return False
if stripped.endswith("```"):
return True
return stripped[-1] in '.!?:)"\']}γ€‚οΌοΌŸοΌšοΌ‰γ€‘γ€γ€γ€‹'
if stripped.endswith('^'):
return True
last = stripped[-1]
if last in '.!?:)"\']}γ€‚οΌοΌŸοΌšοΌ‰γ€‘γ€γ€γ€‹^':
return True
# Emoji ranges (Misc Symbols, Dingbats, Emoticons, Supplemental, etc.)
if ord(last) >= 0x1F300:
return True
return False

def _is_ollama_glm_backend(self) -> bool:
"""Detect the narrow backend family affected by Ollama/GLM stop misreports."""
Expand Down