Deepen Notion API skill and docs - #27915
Conversation
|
Thanks for the detailed Notion skill refresh. I verified the skill_view collision premise against current main, but found a few concrete issues to fix before this is safe to salvage. Problems
Suggested changes
Automated hermes-sweeper review. |
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the substantial Notion API refresh. The underlying Notion skill is still materially stale on current main (skills/productivity/notion/SKILL.md:69 still prescribes 2025-09-03), so the documentation portion is worth salvaging.
Problems
- The
skill_viewcollision change is already present on currentmain:tools/skills_tool.py:1172-1180excludes support paths, andtests/tools/test_skills_tool.py:1228-1261covers the false-collision case. Omit those redundant hunks during salvage. skills/productivity/notion/SKILL.md:3is a 187-character description without a final period.AGENTS.md:888-900requires a <=60-character, one-sentence description ending in a period.skills/productivity/notion/SKILL.md:5should credit the human contributor first (AGENTS.md:926-931).skills/productivity/notion/SKILL.md:14namesweb-apisandoauth-sota, neither of which exists in shipped skill trees; the generated page leaves both unlinked atwebsite/docs/user-guide/skills/bundled/productivity/productivity-notion.md:24.- Add the required skill test at
tests/skills/test_notion_skill.py(AGENTS.md:948-950).
Suggested changes
- Keep the Notion refresh, correct metadata/link targets, regenerate docs, and add the skill-level test.
- The earlier review's malformed authorization-header concern is resolved at this PR head:
SKILL.md:94uses${NOTION_API_KEY}andSKILL.md:366has valid inline Markdown.
Automated hermes-sweeper review.
| description: "Notion API + ntn CLI: pages, databases, markdown, Workers." | ||
| version: 2.0.0 | ||
| author: community | ||
| description: "Use when reading, writing, integrating, or troubleshooting Notion through the REST API, ntn CLI, MCP, webhooks, pages, data sources, markdown, blocks, comments, files, or official JS SDK." |
There was a problem hiding this comment.
This description is 187 characters and does not end with a period. AGENTS.md:888-900 requires a single sentence of at most 60 characters ending in a period; please shorten it before regenerating the catalog.
| author: community | ||
| description: "Use when reading, writing, integrating, or troubleshooting Notion through the REST API, ntn CLI, MCP, webhooks, pages, data sources, markdown, blocks, comments, files, or official JS SDK." | ||
| version: 2.1.0 | ||
| author: community + Hermes Agent |
There was a problem hiding this comment.
Please credit the human contributor first (for example, Danilo Dumeljic (@Danilodum)), with Hermes Agent only as a secondary collaborator, per AGENTS.md:926-931.
| tags: [Notion, Productivity, Notes, Database, API, CLI, Workers] | ||
| tags: [Notion, Productivity, Notes, Data Sources, API, CLI, Markdown, Files, Webhooks, MCP] | ||
| homepage: https://developers.notion.com | ||
| related_skills: [web-apis, oauth-sota, webhook-subscriptions] |
There was a problem hiding this comment.
web-apis and oauth-sota have no matching SKILL.md under either skills/ or optional-skills/, so generated docs render them as dead plain-text references. Remove or retarget them to shipped skills.
| # the thing they document (for example templates/notion.md), and | ||
| # counting those as legacy skills creates false collisions with real | ||
| # directory skills. | ||
| support_dirs = {"references", "templates", "scripts", "assets"} |
There was a problem hiding this comment.
Current main already excludes support paths in this lookup (tools/skills_tool.py:1172-1180) and has a regression test at tests/tools/test_skills_tool.py:1228-1261. Omit this redundant resolver hunk when salvaging the Notion refresh.
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Five PRs are associated with the Notion integration/skill complex. #26 adds an unregistered seven-tool CRUD implementation, #49 only exercises generic tool registration, #52 adds two narrow API helpers, #181 repeats #26's Notion diff alongside an unrelated Windows terminal fix, and #27915 updates the existing bundled skill to the current API and expands its source-backed references.
Related pull requests
- #26 [closed]
related— (+1278/-0) — keep closed: Adds seven Notion API tools, tests, and a skill, but registration is left as a standalone patch snippet rather than integrated into the repository; the contributor review also confirms that a bundled Notion skill already exists. It remains relevant as the source of the Notion code later copied into #181. - #49 [closed]
related— (+54/-21) — keep closed: Despite its Notion title, the diff adds only a generic hello tool and a WIP README line, provides no Notion operation, and unnecessarily rewrites the tool-discovery list. This does not address stale or incomplete Notion guidance, consistent with the contributor's existing-skill objection. - #52 [closed]
related— (+29/-0) — keep closed: Adds title search and database-schema retrieval, but these are narrow, unregistered helpers with no error handling or tests, while title search is already covered by the bundled skill's workflow. The contributor review explicitly identifies it as duplicating an existing Notion skill. - #181 [closed]
related— (+1673/-21) — keep closed and split by concern: Its substantive unique change is the unrelated Windows LocalEnvironment fix; all Notion files are effectively copied from #26 and do not belong in this terminal-fix PR. It remains relevant both as a possible source for a separately scoped Windows fix and as evidence that #26's Notion implementation was duplicated rather than independently advanced. - #27915
related— (+3105/-716) — keep open for focused salvage: The diff directly addresses the stale bundled skill by moving guidance from API version 2025-09-03 to 2026-03-11 and adding source-backed coverage for data sources, markdown, uploads, views, webhooks, MCP, CLI, and SDK surfaces. This agrees with the visible keep_open reviews, but their blocking findings must be fixed first: remove already-main skill_view hunks, repair metadata/attribution and nonexistent related skills, add the required skill test, and correct malformed or invalid Authorization examples.
Duplicates
#26 and the Notion portion of #181 are effectively identical; #52 substantially overlaps the existing bundled Notion search/schema guidance rather than providing a distinct integration. #49 is scaffolding, not an implementation duplicate.
Suggested consolidation
Keep #27915 open and salvage only its Notion skill, references, snapshot script, and regenerated documentation; after explicitly resolving both keep_open reviews' blocking findings and rerunning the required skill/docs checks, merge #27915. Keep #26, #49, and #52 closed as superseded or redundant, and keep #181 closed unless its unrelated Windows LocalEnvironment fix is resubmitted as a clean standalone PR without the duplicated #26 Notion files.
Cross-PR triage: Reviewed 5 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 300 kB of PR diffs, 5 kB of issue/PR text, 4 kB of discussion (9 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
Summary
2026-03-11, data sources, pages, blocks, comments, markdown workflows, file uploads, webhooks, MCP, Workers,ntn, and the official JS SDK.skills/productivity/notion/scripts/notion_api_surface_snapshot.pyfor no-credential Notion API/docs/package surface snapshots and drift checks.skill_viewlegacy flat-file lookup so support files underreferences/,templates/,scripts/, andassets/do not create false skill-name collisions; adds regression coverage.Validation
git diff --check origin/main...HEADPYTHONDONTWRITEBYTECODE=1 scripts/run_tests.sh tests/tools/test_skills_tool.py -q -p no:cacheproviderPYTHONDONTWRITEBYTECODE=1 python - <<'PY' ... ast.parse(...) ... PYpython3 website/scripts/generate-skill-docs.pyplus clean diff check forwebsite/docs/reference/skills-catalog.mdandwebsite/docs/user-guide/skills/bundled/productivity/productivity-notion.md