Skip to content

fix(auxiliary): drop session search from model picker #27835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BoardJames-Bot wants to merge 1 commit into from
Closed

fix(auxiliary): drop session search from model picker #27835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hermes_cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2127,7 +2127,6 @@ def _clear_stale_openai_base_url():
("vision", "Vision", "image/screenshot analysis"),
("compression", "Compression", "context summarization"),
("web_extract", "Web extract", "web page summarization"),
("session_search", "Session search", "past-conversation recall"),
("approval", "Approval", "smart command approval"),
("mcp", "MCP", "MCP tool reasoning"),
("title_generation", "Title generation", "session titles"),
Expand Down
15 changes: 9 additions & 6 deletions tests/hermes_cli/test_aux_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,15 @@ def test_title_generation_present_in_default_config():
assert tg["extra_body"] == {}


def test_session_search_defaults_include_extra_body_and_concurrency():
ss = DEFAULT_CONFIG["auxiliary"]["session_search"]
assert ss["provider"] == "auto"
assert ss["model"] == ""
assert ss["extra_body"] == {}
assert ss["max_concurrency"] == 3
def test_session_search_is_not_aux_model_configurable():
"""Session search no longer uses an auxiliary LLM.

It should not appear in DEFAULT_CONFIG["auxiliary"] or in the auxiliary
model picker, because any saved ``auxiliary.session_search`` settings are
ignored by the single-shape DB-backed session_search tool.
"""
assert "session_search" not in DEFAULT_CONFIG["auxiliary"]
assert all(task != "session_search" for task, _name, _desc in _AUX_TASKS)


def test_aux_tasks_keys_all_exist_in_default_config():
Expand Down