fix(agent): reject oversized base64 images before decoding to prevent OOM - #2779
Closed
dieutx wants to merge 1 commit into
Closed
fix(agent): reject oversized base64 images before decoding to prevent OOM#2779dieutx wants to merge 1 commit into
dieutx wants to merge 1 commit into
Conversation
… OOM base64.b64decode() is called on inline image data with no size check. A maliciously large base64 payload (e.g., 500MB) would decode fully into memory before writing to disk, potentially causing OOM. Add a 50MB base64 length check (~37.5MB decoded) before decoding.
Contributor
Author
|
Closing — #2690 adds comprehensive image size limits (20MB pre-check + post-download) across all image entry points, which covers the OOM prevention this was targeting. The base64 decode path in run_agent.py is a slightly different entry point, but not worth a separate PR given #2690's broader coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_save_anthropic_image_to_temp()callsbase64.b64decode(data)with no size checkHow to reproduce
How to test
Platform tested