fix(skills): load symlinked skill slash commands - #27759
Merged
teknium1 merged 1 commit intoMay 18, 2026
Merged
Conversation
Collaborator
|
Duplicate of #27662 — same fix for symlinked skill slash-command loading in _load_skill_payload(). Both normalize the lexical path under trusted skill roots before resolving symlinks. |
1 task
dev-xyz-0-0
added a commit
to dev-xyz-0-0/hermes-agent
that referenced
this pull request
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/skill-nameinvocations for skills symlinked under~/.hermes/skillsWhy
Skill slash commands cache the discovered skill directory. When that directory is a symlink,
_load_skill_payload()resolved it before normalizing it forskill_view(). If the symlink target lives outside~/.hermes/skills, the loader passed an absolute path through andskill_view()rejected it withNon-relative patterns are unsupported.This keeps the trusted, visible path under the configured skills root intact before falling back to resolved-path handling.
Safety
skill_view()platform, disabled-skill, collision, and warning behavior remains in placeTest Plan
./scripts/run_tests.sh tests/agent/test_skill_commands.py tests/tools/test_skills_tool.py -q./scripts/run_tests.sh tests/agent/test_skill_commands.py::TestScanSkillCommands::test_loads_skill_invocation_from_symlinked_skill_dir -q