fix(signal): evict oldest sent timestamp instead of arbitrary one - #2773
Closed
dieutx wants to merge 1 commit into
Closed
fix(signal): evict oldest sent timestamp instead of arbitrary one#2773dieutx wants to merge 1 commit into
dieutx wants to merge 1 commit into
Conversation
set.pop() removes an arbitrary element, so the echo-back filter could drop a recent timestamp while keeping old ones. This causes the filter to miss actual echo-backs and let duplicate messages through. Use min() to always evict the oldest timestamp.
Contributor
Author
|
Closing — small fix with no tests, cleaning up stale PRs. |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_track_sent_timestamp()usesset.pop()to evict when the echo-back filter exceeds 50 entriesset.pop()removes an arbitrary element, not the oldest — could drop a recent timestamp while keeping old onesmin()to always evict the oldest timestampHow to reproduce
How to test
set.pop()→set.discard(min(set))Platform tested