fix(email): handle missing @ in EMAIL_ADDRESS to prevent IndexError - #2772
Closed
dieutx wants to merge 1 commit into
Closed
fix(email): handle missing @ in EMAIL_ADDRESS to prevent IndexError#2772dieutx wants to merge 1 commit into
dieutx wants to merge 1 commit into
Conversation
The Message-ID generation uses self._address.split('@')[1] which
crashes with IndexError when EMAIL_ADDRESS env var is empty or
malformed (no @ sign). Fall back to 'hermes.local' domain.
Contributor
Author
|
Closing — niche edge case. #2794 takes a broader approach to email adapter hardening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self._address.split('@')[1]at two locations (lines 441, 518)IndexErrorwhenEMAIL_ADDRESSenv var is empty or malformed (no@sign)@before splitting, fall back tohermes.localdomainHow to reproduce
EMAIL_ADDRESS=""orEMAIL_ADDRESS="not-an-email"in .envHow to test
Platform tested