Skip to content

fix(skills): preserve official optional-skill frontmatter names - #27467

Closed
Qwinty wants to merge 6 commits into
NousResearch:mainfrom
Qwinty:fix/official-skill-frontmatter-name
Closed

fix(skills): preserve official optional-skill frontmatter names#27467
Qwinty wants to merge 6 commits into
NousResearch:mainfrom
Qwinty:fix/official-skill-frontmatter-name

Conversation

@Qwinty

@Qwinty Qwinty commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

This fixes the official optional-skill branch of the skill-name mismatch bug class:

  • preserve the SKILL frontmatter name when fetching official optional skills for install
  • treat hub-installed skills as aliases of their installed SKILL frontmatter name in hermes skills list
  • add regressions for install-time naming and list classification

Problem

OptionalSkillSource.fetch() used the directory slug as bundle.name, while official search/list/inspect surface the SKILL frontmatter name.

That creates a mismatch for optional skills whose directory and frontmatter diverge. Example:

  • directory: optional-skills/productivity/here-now/
  • frontmatter: name: here.now

Before this patch:

  1. install records the hub entry under here-now
  2. _find_all_skills() returns here.now
  3. hermes skills list fails to match the hub lock entry and falls through to local

So an official skill can appear as local after install.

This is not dot-specific: I scanned optional-skills/ and found 14 official skills whose directory name differs from frontmatter name, including here.now and devops/cli -> inference-sh-cli.

Why both changes

  • Fetch/install alignment fixes new installs going forward.
  • Frontmatter aliasing in do_list() keeps already-installed skills classified correctly even if they were installed before this patch under the old directory-slug name.

Verification

pytest tests/hermes_cli/test_skills_hub.py -q

Passed locally:

  • 24 passed

Related

@Qwinty

Qwinty commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Closing this PR because the branch accidentally included unrelated changes. I will reopen a clean, minimal PR with only the skills hub fix.

@Qwinty Qwinty closed this May 17, 2026
@Qwinty
Qwinty deleted the fix/official-skill-frontmatter-name branch May 17, 2026 14:44
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard tool/skills Skills system (list, view, manage) labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants