fix(skills): preserve official optional-skill frontmatter names - #27467
Closed
Qwinty wants to merge 6 commits into
Closed
fix(skills): preserve official optional-skill frontmatter names#27467Qwinty wants to merge 6 commits into
Qwinty wants to merge 6 commits into
Conversation
Contributor
Author
|
Closing this PR because the branch accidentally included unrelated changes. I will reopen a clean, minimal PR with only the skills hub fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the official optional-skill branch of the skill-name mismatch bug class:
namewhen fetching official optional skills for installhermes skills listProblem
OptionalSkillSource.fetch()used the directory slug asbundle.name, while official search/list/inspect surface the SKILL frontmatter name.That creates a mismatch for optional skills whose directory and frontmatter diverge. Example:
optional-skills/productivity/here-now/name: here.nowBefore this patch:
here-now_find_all_skills()returnshere.nowhermes skills listfails to match the hub lock entry and falls through tolocalSo an official skill can appear as local after install.
This is not dot-specific: I scanned
optional-skills/and found 14 official skills whose directory name differs from frontmatter name, includinghere.nowanddevops/cli -> inference-sh-cli.Why both changes
do_list()keeps already-installed skills classified correctly even if they were installed before this patch under the old directory-slug name.Verification
Passed locally:
24 passedRelated