fix(kanban): make legacy task migration idempotent - #27459
Closed
ht1072 wants to merge 1 commit into
Closed
Conversation
(cherry picked from commit 293f1c3a7241b0117669e049d9aa746c9645ac90)
Contributor
Author
|
Keeping this PR open as a small idempotency fix for partially migrated legacy kanban task DBs. If there's an existing migration thread this should fold into instead, I'm happy to collapse it rather than keep a duplicate patch alive. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_failures/last_spawn_errormigration path idempotentWhy
Some existing DBs are only partially migrated.
_migrate_add_optional_columns()snapshots the schema once at entry, then performs multipleALTER TABLEsteps. On partially migrated DBs that already contain later columns, using the stale initial snapshot can make the legacy-column migration path try to add columns that already exist. Re-reading the schema after the early additive migrations makes the function safe to run repeatedly.Test Plan