fix(gateway): skip reasoning_content replay for MiniMax models - #27253
Closed
venyon2k wants to merge 1 commit into
Closed
fix(gateway): skip reasoning_content replay for MiniMax models#27253venyon2k wants to merge 1 commit into
venyon2k wants to merge 1 commit into
Conversation
Contributor
Author
ProblemMiniMax models generate per-turn-independent Without this fix,
Fix
Tests
Files
|
Author
|
@teknium1 Hey — this is a clean single-commit PR. Happy to address any feedback. The O(n²) token growth issue is specific to MiniMax; DeepSeek/Kimi/Anthropic are completely unaffected. |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MiniMax models generate per-turn-independent
reasoning_content. Unlike DeepSeek/Kimi which require it preserved in replay to avoid HTTP 400, MiniMax's reasoning is fresh each turn and adds only context bloat when replayed.Fix
_REASONING_BLOAT_PROVIDERS: minimax, minimax-cn, minimax-oauth_is_reasoning_content_replay_bloat_model()— returns True for affected models_build_replay_entry()getsreasoning_bloat_model=Truekwarg — skips reasoning/reasoning_content/reasoning_details when TrueTests
TestReasoningBloatModel: 10 cases (provider slugs, host detection, negative cases)TestBuildReplayEntryWithBloatModel: 4 cases (field suppression, non-reasoning field preservation)Files
gateway/run.py(+57/-2)tests/gateway/test_replay_entry_fields.py(+128/-2)