fix(gateway): add module logger and unblock PR 27246 - #27249
Closed
psyduckler wants to merge 4 commits into
Closed
Conversation
…all_platforms hermes_cli/gateway.py:3702 referenced logger.debug() but 'logger' was never defined in the module, causing a NameError at runtime if the try/except around discover_plugins() caught an exception. Added import logging and logger = logging.getLogger(__name__) at module level to resolve the undefined name.
…ousResearch#27154) Verify that the module has a logger instance with the correct name, preventing regression of the NameError fixed in a31d5af.
Author
|
Closing: opened against the wrong repo/PR context. Please ignore. |
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainscripts/release.pyAUTHOR_MAPmerge conflict by keeping both the PR's author-map entries and the new batch salvage entries frommainhermes_cli/send_cmd.pyby adding an explicit UTF-8 encoding toPath.read_text(...)Validation
python -m ruff check .→ pass./scripts/run_tests.sh tests/hermes_cli/test_gateway.py -q→ 28 passed./scripts/run_tests.sh tests/hermes_cli/test_send_cmd.py -q→ 20 passedSupersedes/unsticks #27246; original upstream PR branch could not be pushed to from my auth context.