fix(plugins): use path keys for bundled platform plugins - #27240
felix-windsor wants to merge 1 commit into
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
811239b to
4b28b21
Compare
|
Rebased on latest Local verification:
Marked ready for review. |
4b28b21 to
a1fc963
Compare
|
Rebased on latest Local verification:
(Still seeing no CI statuses reported on the PR head; may need maintainer Actions approval for fork PRs.) |
a1fc963 to
fd2eaf7
Compare
|
Thanks for the focused fix. The premise remains valid on current main: runtime discovery scans The proposed prefix-aware scan fixes the entire bundled-platform category rather than only Teams, while the regression test verifies the representative mismatch. The test is a behavioral contract between runtime discovery and the established path-key model, not a catalog snapshot. GitHub currently reports the PR mergeable. This is an automated hermes-sweeper review. |
|
Thanks @felix-windsor — this fix landed on main as a slim redo in #118854 (405975a), which credits this PR and closes #27548. Closing as superseded. |
Summary
plugins/platforms/*with the same path-derived key shape used by the general plugin scannerplatforms/<name>instead of bare manifest names liketeams-platformWhy
hermes plugins listand the docs surface sub-category plugins by path key, for exampleplatforms/teams. Runtime discovery scanned the bundledplugins/platformsdirectory as a separate root, so PluginManager recorded the same plugin asteams-platform. That made runtime state diverge from the key users see in plugin management surfaces.Open PR overlap checked
gateway/config.py; this PR does not touch gateway config orHERMES_BUNDLED_PLUGINS.hermes_cli/plugins.py; it touchesVALID_HOOKS, not the bundled platform scanner.Verification
./scripts/run_tests.sh tests/hermes_cli/test_plugin_scanner_recursion.py::TestBundledBackendAutoLoad::test_bundled_platform_plugins_use_path_derived_keys tests/hermes_cli/test_plugin_scanner_recursion.py::TestBundledBackendAutoLoad::test_bundled_image_gen_openai_autoloads tests/gateway/test_plugin_platform_interface.py./scripts/run_tests.sh tests/hermes_cli/test_plugin_scanner_recursion.py.venv/bin/ruff check hermes_cli/plugins.py tests/hermes_cli/test_plugin_scanner_recursion.pygit diff --check