fix(agent): continue after Chinese local-file ack before tool calls - #26913
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(agent): continue after Chinese local-file ack before tool calls#26913LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
This comment was marked as spam.
This comment was marked as spam.
This was referenced Jun 30, 2026
Contributor
|
Thanks for the focused regression case. The underlying CJK failure is still present on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes premature turn completion when the model emits a Chinese "starting now" acknowledgement for a tool-required local file-writing task, but has not called any tool yet.
The agent now treats this as an intermediate acknowledgement and auto-continues so the next call can emit actual tool calls.
Related Issue
Fixes #26892
Type of Change
Changes Made
AIAgent._looks_like_codex_intermediate_ack(...)inrun_agent.py:保存到本地,写入文件,save to file, etc.).test_run_conversation_codex_continues_after_chinese_ack_for_local_file_writeintests/run_agent/test_run_agent_codex_responses.py.How to Test
uv run --extra dev python -m pytest -q tests/run_agent/test_run_agent_codex_responses.py -k chinese_ack_for_local_file_writeuv run --extra dev python -m pytest -q tests/run_agent/test_run_agent_codex_responses.py -k continues_after_ackpython3 -m py_compile run_agent.py tests/run_agent/test_run_agent_codex_responses.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
1 passedfor-k chinese_ack_for_local_file_write2 passedfor-k continues_after_ack