Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
Local verification update after the automated reviewer comment: The I re-ran the PR test plan locally on the PR branch: python3 -m pytest tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_repeated_rate_limits_open_circuit_for_followup_sends tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_open_rate_limit_circuit_fails_fast_without_sendmessage tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_successful_send_after_cooldown_resets_rate_limit_state tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_concurrent_rate_limited_sends_are_serialized_by_gate tests/gateway/test_weixin.py::TestWeixinSendMessageIntegration::test_send_to_platform_routes_weixin_media_to_native_helper -q -o 'addopts='
python3 -m pytest tests/gateway/test_weixin.py -q -o 'addopts='
python3 -m pytest tests/tools/test_send_message_tool.py tests/tools/test_send_message_missing_platforms.py -q -o 'addopts='
git diff --check
python3 -m py_compile gateway/platforms/weixin.py tools/send_message_tool.pyResults:
|
This was referenced May 23, 2026
Open
Collaborator
|
Merged via PR #41718 (commit b8469a8 on main). Your circuit-breaker commit was cherry-picked onto current main with your authorship preserved via rebase-merge. The only adjustment was resolving a conflict in send_message_tool.py where the file had drifted to a registry-based structure — your intended single early-return for WEIXIN was preserved. Thanks @haran2001! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-2frequency-limit responses stop follow-up sends during a cooldown instead of spinning retry loops.Duplicate PR check
Test Plan
python -m pytest tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_repeated_rate_limits_open_circuit_for_followup_sends tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_open_rate_limit_circuit_fails_fast_without_sendmessage tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_successful_send_after_cooldown_resets_rate_limit_state tests/gateway/test_weixin.py::TestWeixinChunkDelivery::test_concurrent_rate_limited_sends_are_serialized_by_gate tests/gateway/test_weixin.py::TestWeixinSendMessageIntegration::test_send_to_platform_routes_weixin_media_to_native_helper -q -o 'addopts='python -m pytest tests/gateway/test_weixin.py -q -o 'addopts='python -m pytest tests/tools/test_send_message_tool.py tests/tools/test_send_message_missing_platforms.py -q -o 'addopts='git diff --check && python -m py_compile gateway/platforms/weixin.py tools/send_message_tool.pyNote:
python -m pytest tests/gateway/ -q -o 'addopts='was attempted locally but the broad gateway suite exhausted the macOS file descriptor limit and timed out withOSError: [Errno 24] Too many open files; the targeted Weixin/send-message coverage above passed.Closes #26828