Fix QQBot reconnect lifecycle after transient websocket disconnects - #26878
Closed
yiantong35 wants to merge 1 commit into
Closed
Fix QQBot reconnect lifecycle after transient websocket disconnects#26878yiantong35 wants to merge 1 commit into
yiantong35 wants to merge 1 commit into
Conversation
Collaborator
yiantong35
force-pushed
the
fix/qqbot-reconnect-lifecycle
branch
from
May 16, 2026 11:16
4ddf217 to
6ed64a3
Compare
Contributor
|
Thanks for the careful reconnect analysis. This automated hermes-sweeper review found that the lifecycle guarantee is already implemented on current
The member's related-heartbeat discussion maps to the same symptom, but the requested lifecycle behavior is now present on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix QQBot reconnect lifecycle after transient websocket disconnects
Branch prepared locally:
Commit:
Fork remote:
Title
Body
Result:
Then create the PR:
Direct compare URL after push:
Current Blocker
The code, branch, commit, and tests are ready. Push is blocked only by GitHub
authentication on this machine:
Do not paste a GitHub token into chat. Authenticate locally with GitHub CLI,
Git Credential Manager, or an SSH key, then rerun the push command above.