feat(kanban): add configurable gateway notification profiles - #26874
Closed
whirmill wants to merge 1 commit into
Closed
feat(kanban): add configurable gateway notification profiles#26874whirmill wants to merge 1 commit into
whirmill wants to merge 1 commit into
Conversation
Contributor
|
Thanks @whirmill — closing this one. 875 LOC of UX policy (notification profiles, thread naming, dispatch behavior tweaks) is substantive design territory. It also overlaps with #26348 (notification_sources, already merged) and the existing per-task notify-sub model. Worth doing if there's a concrete gap the existing surfaces don't fill, but the design conversation needs to come first. If you want to revisit as a fresh focused PR, happy to take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python -m pytest tests/gateway/test_kanban_notifier.py tests/hermes_cli/test_kanban_notify.py -o 'addopts=' -q272 passedNotes
This is intentionally separate from the Discord handoff membership fix and the model/context fallback fixes so the upstream review can evaluate the Kanban UX policy independently.