fix(tools): run post_setup in _reconfigure_provider() for env-var providers - #26642
Closed
EloquentBrush0x wants to merge 1 commit into
Closed
Conversation
…viders _configure_provider() calls _run_post_setup() after collecting env vars (line 2286). _reconfigure_provider() did not — providers with both env_vars and post_setup (Browserbase, Browser Use, Firecrawl, Camofox) skipped the installation step on reconfiguration. Fix: mirror the _configure_provider() call. post_setup hooks are idempotent (check before installing), so no behaviour change for users who already have the dependencies installed.
alt-glitch
added
type/bug
teknium1
added a commit
that referenced
this pull request
May 17, 2026
Contributor
|
Merged via #27306 with your authorship preserved via rebase-merge. Commit |
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Seven74AI
pushed a commit
to Seven74AI/hermes-agent
that referenced
this pull request
Jun 13, 2026
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
liuchanchen
pushed a commit
to liuchanchen/hermes-agent
that referenced
this pull request
Jun 23, 2026
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_configure_provider()calls_run_post_setup()after collecting env vars (line 2286)._reconfigure_provider()— added in the same file — skips this call for providers with bothenv_varsandpost_setup(Browserbase, Browser Use, Firecrawl, Camofox). A user who configures one of these providers via/reconfigure toolsgets their API key saved but theagent_browsernpm install never runs, breaking the browser tool at runtime.One-line fix mirroring
_configure_provider. Hooks are idempotent so no behaviour change for existing installs.Related Issue
N/A
Type of Change
Changes Made
hermes_cli/tools_config.py: add_run_post_setup()call in_reconfigure_provider()(+2 lines)tests/hermes_cli/test_tools_config.py: parametrized regression for all four affected providersHow to Test
Checklist