Skip to content

fix(vision): preserve named custom providers - #26544

Closed
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/custom-vision-provider
Closed

fix(vision): preserve named custom providers#26544
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/custom-vision-provider

Conversation

@haran2001

Copy link
Copy Markdown
Contributor

Summary

  • Preserve custom:<name> provider identifiers during auxiliary/vision provider normalization.
  • Add a regression test that explicit named custom vision overrides route through resolve_provider_client() instead of the strict/default custom backend.

Test Plan

  • python -m pytest tests/agent/test_auxiliary_main_first.py::TestResolveVisionMainFirst::test_named_custom_provider_override_preserves_custom_prefix -q -o 'addopts='

Closes #12638

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint tool/vision Vision analysis and image generation labels May 15, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused regression report and test.

Automated hermes-sweeper review found the requested routing behavior is already implemented on current main:

  • agent/auxiliary_client.py:5286-5289 normalizes the explicit vision provider; named custom providers then take the generic _get_cached_client() route rather than a strict vision backend.
  • agent/auxiliary_client.py:4435-4442 and :4715-4817 retain the pre-normalized identifier where needed and resolve the normalized named-provider suffix through _get_named_custom_provider().
  • Commit 8ec1608642973fec9fcd90e962b11f9c18414247 deliberately removed the prior vision-specific custom-provider collapse; tests/agent/test_auxiliary_named_custom_providers.py:60-62 now guards the suffix-based behavior.
  • The linked issue Withdrawn: vision provider routing report #12638 was withdrawn after this current-main behavior was identified.

Closing as implemented on main.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Withdrawn: vision provider routing report

3 participants