Skip to content

fix(codex-runtime): reapply migration when already enabled - #26535

Closed
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix/reapply-codex-runtime-migration
Closed

fix(codex-runtime): reapply migration when already enabled#26535
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix/reapply-codex-runtime-migration

Conversation

@aqilaziz

Copy link
Copy Markdown
Contributor

Fixes #26529

Summary

  • allow /codex-runtime codex_app_server to re-run the Codex config migration when model.openai_runtime is already codex_app_server
  • keep the auto no-op path unchanged
  • skip config persistence on reapply while still running the idempotent MCP/plugin migration
  • add a regression test covering the reapply path

Tests

  • python -m pytest -o addopts='' tests\hermes_cli\test_codex_runtime_switch.py -q --tb=short
  • python -m py_compile hermes_cli\codex_runtime_switch.py tests\hermes_cli\test_codex_runtime_switch.py
  • python -m ruff check hermes_cli\codex_runtime_switch.py tests\hermes_cli\test_codex_runtime_switch.py
  • git diff --check

@aqilaziz
aqilaziz force-pushed the fix/reapply-codex-runtime-migration branch from 5d6c23a to e5b27ed Compare May 15, 2026 19:17
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard provider/openai OpenAI / Codex Responses API P2 Medium — degraded but workaround exists labels May 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix: #26532 by @simpolism (issue author) targets the same bug with the same approach. Both modify codex_runtime_switch.py identically in logic. Maintainer should pick one.

@aqilaziz
aqilaziz force-pushed the fix/reapply-codex-runtime-migration branch from 9699f03 to 8ed0e0b Compare May 15, 2026 22:40
@aqilaziz

Copy link
Copy Markdown
Contributor Author

Thanks for flagging. I’m fine with maintainers taking #26532 if they prefer the issue-author branch; this PR can serve as an alternate or be closed if #26532 lands first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/openai OpenAI / Codex Responses API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/codex-runtime codex_app_server silently skips migration when openai_runtime already set in config

2 participants